Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Observability with support of OpenTelemetry #1774

Closed
hanyuancheung opened this issue Mar 6, 2022 · 7 comments
Closed

Enhance Observability with support of OpenTelemetry #1774

hanyuancheung opened this issue Mar 6, 2022 · 7 comments

Comments

@hanyuancheung
Copy link

What would you like to be added

As the migration of OpenTracing and OpenCensus, OpenTelemetry becomes the standard in the observability field. I've checked the related module in dubbo-go(including dubbo-go-sample), and now still use OpenTracing to exporter trace signal to Jaeger or Zipkin backend, as well as use Prometheus to exporter metrics signal to backend.

Proposed Solution

I wonder if you guys like to integrate the ability of the OpenTelemetry, package into the independent module, which is for the use of external users, code structure like below:

  • observability
    • tracing
    • metrics
    • other signals

Alternatives

Because opentelemetry-collector-contrib provides all different kinds of receivers, so users could deploy collector component by using like jaegerreceiver or zipkinreceiver, and the data model is transformed from OpenTracing to OpenTelemetry automatically.
I do not know which way dubbo-go community prefer.
If the former way looks good, I'll work on it to provide an OpenTelemetry version module. If latter, I'll add doc or readme to let users know how to use OpenTracing to export trace and metrics into OpenTelemetry backend.

@hanyuancheung
Copy link
Author

@AlexStocks PTAL.

@AlexStocks
Copy link
Contributor

AlexStocks commented Mar 6, 2022

@AlexStocks PTAL.

I prefer the former solution. So pls add an solution to integrate the OpenTelemetry into dubbogo.

@XiaoWeiKIN
Copy link
Contributor

mark

@AlexStocks
Copy link
Contributor

AlexStocks commented Mar 28, 2022

@hanyuancheung how is this task going now?

@LaurenceLiZhixin
Copy link
Contributor

cc @pherzheyu

@pherzheyu
Copy link
Contributor

OpenTelemetry trace is already a stable feature. Going on.

@hanyuancheung
Copy link
Author

hanyuancheung commented Apr 11, 2022

@hanyuancheung how is this task going now?

Yeah, I've been working on it. Sorry that I've been slowed down by being too busy recently. I'll finish it as soon as possible.

cc @pherzheyu @AlexStocks

pherzheyu added a commit to pherzheyu/dubbo-go that referenced this issue Apr 30, 2022
pherzheyu added a commit to pherzheyu/dubbo-go that referenced this issue May 1, 2022
AlexStocks pushed a commit that referenced this issue May 2, 2022
* godoc (#1755)

* update package comment (#1755)

* imports formatter (#1755)

* filter/graceful_shutdown license (#1755)

* filter/graceful_shutdown license (#1755)

* update some comment (#1755)

* gofmt (#1755)

* Update version.go

comment for blank (#1755)

* comment for blank (#1755)

* comment (#1755)

* ut mock nacos and etcd (#1774)

* mock nacos nolint

* mock etcd nolint

* ut mock update (#1774)
pherzheyu added a commit to pherzheyu/dubbo-go that referenced this issue May 5, 2022
pherzheyu added a commit to pherzheyu/dubbo-go that referenced this issue May 5, 2022
pherzheyu added a commit to pherzheyu/dubbo-go that referenced this issue May 5, 2022
AlexStocks pushed a commit that referenced this issue May 7, 2022
* remove meshrouter and v3router (#1774)

* remove meshrouter v3router constant (#1774)
pherzheyu added a commit to pherzheyu/dubbo-go that referenced this issue May 10, 2022
pherzheyu added a commit to pherzheyu/dubbo-go that referenced this issue May 16, 2022
AlexStocks pushed a commit that referenced this issue May 17, 2022
* otel trace (#1774)

* metdata use map (#1774)

* metadata update

* otel version use dubbo version

* update version ut

* update version ut
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants