Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix:nacos client reuse #1633

Merged
merged 16 commits into from
Feb 1, 2022
Merged

Fix:nacos client reuse #1633

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
f19a829
up:处理nacos客户端共用问题
zhaoyunxing92 Dec 2, 2021
dbc19ce
fmt:import
zhaoyunxing92 Dec 2, 2021
d816d3c
Merge remote-tracking branch 'origin/3.0' into fix-nacos
zhaoyunxing92 Dec 12, 2021
39409b2
up:更新客户端获取
zhaoyunxing92 Dec 30, 2021
7021da8
修复测试用例问题
zhaoyunxing92 Dec 30, 2021
26fab4a
up:测试问题
zhaoyunxing92 Dec 30, 2021
dc6154a
fmt
zhaoyunxing92 Dec 30, 2021
8c2a9e3
修复测试用例
zhaoyunxing92 Dec 30, 2021
1eaa349
fmt
zhaoyunxing92 Dec 30, 2021
816ae72
修改impl测试问题
zhaoyunxing92 Jan 3, 2022
481de45
Merge remote-tracking branch 'upstream/3.0' into fix-nacos
zhaoyunxing92 Jan 4, 2022
371012a
Merge branch '3.0' into fix-nacos
zhaoyunxing92 Jan 14, 2022
81757f2
Merge remote-tracking branch 'origin/3.0' into fix-nacos
zhaoyunxing92 Jan 18, 2022
0951444
fix:测试用例
zhaoyunxing92 Jan 18, 2022
afe5605
Merge remote-tracking branch 'upstream/3.0' into fix-nacos
zhaoyunxing92 Jan 27, 2022
e7ddc1e
fix:修改应用级服务发现
zhaoyunxing92 Jan 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
修复测试用例问题
  • Loading branch information
@zhaoyunxing92
zhaoyunxing92 committed Dec 30, 2021
commit 7021da83e740f90692892ade9502c6e07000641e
4 changes: 1 addition & 3 deletions remoting/nacos/builder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,6 @@ import (
"dubbo.apache.org/dubbo-go/v3/config"
)

const nacosClientName = "nacos-client"

// NewNacosConfigClientByUrl read the config from url and build an instance
func NewNacosConfigClientByUrl(url *common.URL) (*nacosClient.NacosConfigClient, error) {
sc, cc, err := GetNacosConfig(url)
Expand Down Expand Up @@ -138,5 +136,5 @@ func NewNacosClientByURL(url *common.URL) (*nacosClient.NacosNamingClient, error
return nil, perrors.New("nacos client name must set")
}
logger.Infof("[Nacos Client] New nacos client with config = %+v", scs)
return nacosClient.NewNacosNamingClient(nacosClientName, true, scs, cc)
return nacosClient.NewNacosNamingClient(clientName, true, scs, cc)
}
1 change: 1 addition & 0 deletions remoting/nacos/builder_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,7 @@ func getRegUrl() *common.URL {
// regurlMap.Set(constant.NacosPassword, "nacos")
regurlMap.Set(constant.NacosNamespaceID, "nacos")
regurlMap.Set(constant.TimeoutKey, "5s")
regurlMap.Set(constant.ClientNameKey, "nacos-client")

regurl, _ := common.NewURL("registry://console.nacos.io:80", common.WithParams(regurlMap))

Expand Down