Fix:nacos client reuse #1633
Merged
Fix:nacos client reuse #1633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
本地跑下单元测试，应该是有问题的 |
|
@zhaoyunxing92 You can merge 3.0 and try again. |
LaurenceLiZhixin
approved these changes
Jan 27, 2022
cjphaha
approved these changes
Jan 27, 2022
|
cc @sanxun0325 |
justxuewei
reviewed
Jan 28, 2022
| @@ -69,6 +69,11 @@ func (CenterConfig) Prefix() string { | |||
| return constant.ConfigCenterPrefix | |||
| } | |||
|
|
|||
| // NameId unique identifier id for client | |||
| func (c *CenterConfig) NameId() string { | |||
There was a problem hiding this comment.
You may use ID instead of Id.
binbin0325
reviewed
Jan 28, 2022
| // NewNacosConfigClientByUrl read the config from url and build an instance | ||
| func NewNacosConfigClientByUrl(url *common.URL) (*nacosClient.NacosConfigClient, error) { | ||
| sc, cc, err := GetNacosConfig(url) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| return nacosClient.NewNacosConfigClient(nacosClientName, true, sc, cc) | ||
| clientName := url.GetParam(constant.ClientNameKey, "") |
There was a problem hiding this comment.
按照这个pr的实现理论上应该都可以在url获取到clientName，如果没有获取到是不是默认生成一下nameID更好，不抛出错误。
There was a problem hiding this comment.
我理解应该需要强制抛异常，使用默认又会导致全局只有一个client配置
| @@ -69,6 +69,11 @@ func (CenterConfig) Prefix() string { | |||
| return constant.ConfigCenterPrefix | |||
| } | |||
|
|
|||
| // NameId unique identifier id for client | |||
| func (c *CenterConfig) NameId() string { | |||
There was a problem hiding this comment.
NameId func 好几个文件都有实现，可以提取到一个公共函数中么，接收实现的Prefix的interface就好
AlexStocks
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
目前创建nacos客户端的时候出现复用链接问题，会导致配置文件最终只有一个生效
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: