fix(config): fix the type of reject request (#1749)

apache · Feb 11, 2022 · 2cf7424 · 2cf7424
1 parent 58eef8b
commit 2cf7424
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/config/graceful_shutdown_config.go b/config/graceful_shutdown_config.go
@@ -67,7 +67,7 @@ type ShutdownConfig struct {
 	InternalSignal bool `default:"true" yaml:"internal-signal" json:"internal.signal,omitempty" property:"internal.signal"`
 
 	// true -> new request will be rejected.
-	RejectRequest bool
+	RejectRequest atomic.Bool
 	// active invocation
 	ConsumerActiveCount atomic.Int32
 	ProviderActiveCount atomic.Int32
@@ -138,7 +138,7 @@ func (scb *ShutdownConfigBuilder) SetRejectRequestHandler(rejectRequestHandler s
 }
 
 func (scb *ShutdownConfigBuilder) SetRejectRequest(rejectRequest bool) *ShutdownConfigBuilder {
-	scb.shutdownConfig.RejectRequest = rejectRequest
+	scb.shutdownConfig.RejectRequest.Store(rejectRequest)
 	return scb
 }
 

diff --git a/config/graceful_shutdown_config_test.go b/config/graceful_shutdown_config_test.go
@@ -28,7 +28,7 @@ import (
 
 func TestShutdownConfigGetTimeout(t *testing.T) {
 	config := ShutdownConfig{}
-	assert.False(t, config.RejectRequest)
+	assert.False(t, config.RejectRequest.Load())
 
 	config = ShutdownConfig{
 		Timeout:     "60s",

diff --git a/filter/graceful_shutdown/procider_filter_test.go b/filter/graceful_shutdown/procider_filter_test.go
@@ -65,7 +65,7 @@ func TestProviderFilterInvoke(t *testing.T) {
 	assert.NotNil(t, result)
 	assert.Nil(t, result.Error())
 
-	config.GetShutDown().RejectRequest = true
+	config.GetShutDown().RejectRequest.Store(true)
 	result = filter.Invoke(context.Background(), protocol.NewBaseInvoker(url), invocation)
 	assert.NotNil(t, result)
 	assert.NotNil(t, result.Error().Error(), "Rejected")

diff --git a/filter/graceful_shutdown/provider_filter.go b/filter/graceful_shutdown/provider_filter.go
@@ -89,7 +89,7 @@ func (f *providerGracefulShutdownFilter) rejectNewRequest() bool {
 	if f.shutdownConfig == nil {
 		return false
 	}
-	return f.shutdownConfig.RejectRequest
+	return f.shutdownConfig.RejectRequest.Load()
 }
 
 func (f *providerGracefulShutdownFilter) getRejectHandler() filter.RejectedExecutionHandler {