Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): fix the type of reject request #1749

Merged
merged 1 commit into from
Feb 11, 2022

Conversation

justxuewei
Copy link
Member

What this PR does:

The PR #1731 wants to use atomic package, but forgot to change the type of the RejectRequest, this PR fixed this problem.

Which issue(s) this PR fixes:
Fixes #1731

You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed

  • All ut passed (run 'go test ./...' in project root)
  • After go-fmt ed , run 'go fmt project' using goland.
  • Golangci-lint passed, run 'sudo golangci-lint run' in project root.
  • After import formatted, (using imports-formatter to run 'imports-formatter .' in project root, to format your import blocks, mentioned in CONTRIBUTING.md above)
  • Your new-created file needs to have apache license at the top, like other existed file does.
  • All integration test passed. You can run integration test locally (with docker env). Clone our dubbo-go-samples project and replace the go.mod to your dubbo-go, and run 'sudo sh start_integration_test.sh' at root of samples project root. (M1 Slice is not Support)

@codecov-commenter
Copy link

Codecov Report

Merging #1749 (3de90cf) into 3.0 (3cb4d1b) will increase coverage by 0.05%.
The diff coverage is 45.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##              3.0    #1749      +/-   ##
==========================================
+ Coverage   42.68%   42.74%   +0.05%     
==========================================
  Files         256      256              
  Lines       14782    14792      +10     
==========================================
+ Hits         6310     6323      +13     
+ Misses       7750     7745       -5     
- Partials      722      724       +2     
Impacted Files Coverage Δ
common/extension/metadata_remote.go 0.00% <ø> (ø)
config/graceful_shutdown.go 4.00% <0.00%> (ø)
config/graceful_shutdown_config.go 28.88% <0.00%> (ø)
config/metadata_report_config.go 21.68% <0.00%> (-0.82%) ⬇️
config/remote_config.go 7.93% <0.00%> (-0.40%) ⬇️
config/root_config.go 45.78% <0.00%> (+1.40%) ⬆️
registry/protocol/protocol.go 72.42% <0.00%> (ø)
filter/graceful_shutdown/consumer_filter.go 79.16% <50.00%> (ø)
remoting/nacos/builder.go 73.91% <50.00%> (-6.09%) ⬇️
registry/nacos/listener.go 78.26% <62.50%> (+0.29%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58eef8b...3de90cf. Read the comment docs.

@zhaoyunxing92 zhaoyunxing92 merged commit 2cf7424 into apache:3.0 Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants