Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pointer value set #361

Merged
merged 5 commits into from
May 6, 2023
Merged

fix pointer value set #361

merged 5 commits into from
May 6, 2023

Conversation

tiltwind
Copy link
Contributor

@tiltwind tiltwind commented May 4, 2023

What this PR does:
From v1.12.0, hessian starts to support pointer value ref to java wrapper types, but the unit tests does not fully cover all cases. This pr fixes the pointer value set.

Which issue(s) this PR fixes:

Fixes #358

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

- fix pointer value set

@codecov-commenter
Copy link

codecov-commenter commented May 4, 2023

Codecov Report

Merging #361 (1dc8c16) into master (7231dc5) will increase coverage by 0.37%.
The diff coverage is 77.46%.

❗ Current head 1dc8c16 differs from pull request most recent head f9c7f78. Consider uploading reports for the commit f9c7f78 to get more accurate results

@@            Coverage Diff             @@
##           master     #361      +/-   ##
==========================================
+ Coverage   68.60%   68.98%   +0.37%     
==========================================
  Files          28       28              
  Lines        3217     3140      -77     
==========================================
- Hits         2207     2166      -41     
+ Misses        775      751      -24     
+ Partials      235      223      -12     
Impacted Files Coverage Δ
java_lang.go 100.00% <ø> (ø)
object.go 72.93% <0.00%> (+3.30%) ⬆️
ref.go 83.11% <ø> (ø)
decode.go 69.82% <73.91%> (+0.64%) ⬆️
codec.go 70.43% <82.22%> (+5.21%) ⬆️
list.go 86.34% <100.00%> (ø)

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@alpha-baby
Copy link

good

@wongoo
Copy link
Contributor

wongoo commented May 5, 2023

dubbo-go integration test , ref apache/dubbo-go#2312

@AlexStocks AlexStocks merged commit 8840018 into apache:master May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

decode Integer -> *int32 报错
5 participants