Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade hessian2 to fix java wrapper object decoding bug #2312

Merged
merged 3 commits into from
May 31, 2023

Conversation

tiltwind
Copy link
Contributor

@tiltwind tiltwind commented May 5, 2023

upgrade hessian2 to fix java wrapper object decoding bug.

see: apache/dubbo-go-hessian2#358

@wongoo
Copy link
Contributor

wongoo commented May 6, 2023

There is an error in the integration test. This PR only contains some fix for hessian serialization. But the error is about registering server. Can anyone help to see what's problem? @justxuewei

2023-05-05T17:04:22.820Z	INFO	config/config_loader.go:95	Starting register instance address &{10.1.0.86:20000 myApp 10.1.0.86 20000 true true map[dubbo.endpoints:[{"port":20000,"protocol":"dubbo"}] dubbo.metadata-service.url-params:{"application":"myApp","group":"myApp","port":"35667","protocol":"dubbo","release":"dubbo-golang-3.0.4","timestamp":"1683306262","version":"1.0.0"} dubbo.metadata.revision:4260813324 dubbo.metadata.storage-type:local dubbo.subscribed-services.revision:0] <nil>   []}
panic: could not register the instance. myApp: Polaris-1004(ErrCodeAPITimeoutError): fail to do register after retry 1 times, cause: Polaris-1007(ErrCodeNetworkError): fail to get connection, opKey RegisterInstance, cause: fail to connect to 183.47.111.80:8091, timeout is 500.114724ms, service is {ServiceKey: {namespace: "Polaris", service: "polaris-default"}, ClusterType: builtin}, because context deadline exceeded

goroutine 1 [running]:
dubbo.apache.org/dubbo-go/v3/config.registerServiceInstance()
	/home/runner/go/pkg/mod/github.com/wongoo/dubbo-go/v3@v3.0.0-20230505162950-4eed5e60614e/config/config_loader.go:98 +0x28b
dubbo.apache.org/dubbo-go/v3/config.(*RootConfig).Start.func1()
	/home/runner/go/pkg/mod/github.com/wongoo/dubbo-go/v3@v3.0.0-20230505162950-4eed5e60614e/config/root_config.go:216 +0x4f
sync.(*Once).doSlow(0x40f8a7, 0xa8)
	/opt/hostedtoolcache/go/1.17.13/x64/src/sync/once.go:68 +0xd2
sync.(*Once).Do(...)
	/opt/hostedtoolcache/go/1.17.13/x64/src/sync/once.go:59
dubbo.apache.org/dubbo-go/v3/config.(*RootConfig).Start(0x1a41ae0)
	/home/runner/go/pkg/mod/github.com/wongoo/dubbo-go/v3@v3.0.0-20230505162950-4eed5e60614e/config/root_config.go:210 +0x46
dubbo.apache.org/dubbo-go/v3/config.(*RootConfig).Init(0xc00012f4a0)
	/home/runner/go/pkg/mod/github.com/wongoo/dubbo-go/v3@v3.0.0-20230505162950-4eed5e60614e/config/root_config.go:205 +0x565
dubbo.apache.org/dubbo-go/v3/config.Load({0x0, 0x1804800, 0xc0000001a0})
	/home/runner/go/pkg/mod/github.com/wongoo/dubbo-go/v3@v3.0.0-20230505162950-4eed5e60614e/config/config_loader.go:59 +0xb1
main.main()
	/home/runner/work/dubbo-go/dubbo-go/samples/polaris/registry/go-server/cmd/server.go:82 +0x25

@wongoo wongoo requested a review from zhaoyunxing92 May 6, 2023 01:45
@sonarcloud
Copy link

sonarcloud bot commented May 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@tiltwind tiltwind changed the title [WIP] upgrade hessian2 to test bug fix upgrade hessian2 to fix java wrapper object decoding bug May 6, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #2312 (f35b3f4) into main (4b13d2b) will increase coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2312      +/-   ##
==========================================
+ Coverage   44.05%   44.15%   +0.09%     
==========================================
  Files         285      294       +9     
  Lines       17669    17845     +176     
==========================================
+ Hits         7784     7879      +95     
- Misses       9057     9128      +71     
- Partials      828      838      +10     

see 30 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AlexStocks AlexStocks merged commit 4309dc5 into apache:main May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants