Skip to content

[fix](cast)Allow cast array, struct and map type to stringlike type. #57326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 26, 2025
Merged

[fix](cast)Allow cast array, struct and map type to stringlike type. #57326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 0 additions & 29 deletions fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/check/CheckCast.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,37 +401,8 @@ && check(((MapType) originalType).getValueType(), ((MapType) targetType).getValu
} else if (originalType.isComplexType() && targetType.isJsonType()) {
return !checkTypeContainsType(originalType, MapType.class);
} else {
return checkPrimitiveType(originalType, targetType);
}
}

/**
* forbid this original and target type
* 1. original type is object type
* 2. target type is object type
* 3. original type is same with target type
* 4. target type is null type
*/
private static boolean checkPrimitiveType(DataType originalType, DataType targetType) {
if (originalType.isJsonType() || targetType.isJsonType()) {
return true;
}
if (!originalType.isPrimitive() || !targetType.isPrimitive()) {
return false;
}
if (originalType.equals(targetType)) {
return false;
}
if (originalType.isNullType()) {
return true;
}
if (originalType.isObjectType() || targetType.isObjectType()) {
return false;
}
if (targetType.isNullType()) {
return false;
}
return true;
}

/**
Expand Down
48 changes: 24 additions & 24 deletions fe/fe-core/src/test/java/org/apache/doris/nereids/rules/expression/check/CheckCastTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1613,11 +1613,11 @@ public void testCastFromArray() {
Assertions.assertFalse(CheckCast.check(ArrayType.SYSTEM_DEFAULT, TimeV2Type.MAX, true));
Assertions.assertFalse(CheckCast.check(ArrayType.SYSTEM_DEFAULT, IPv4Type.INSTANCE, true));
Assertions.assertFalse(CheckCast.check(ArrayType.SYSTEM_DEFAULT, IPv6Type.INSTANCE, true));
Assertions.assertFalse(CheckCast.check(ArrayType.SYSTEM_DEFAULT, CharType.SYSTEM_DEFAULT, true));
Assertions.assertFalse(CheckCast.check(ArrayType.SYSTEM_DEFAULT, VarcharType.SYSTEM_DEFAULT, true));
Assertions.assertFalse(CheckCast.check(ArrayType.SYSTEM_DEFAULT, StringType.INSTANCE, true));
Assertions.assertTrue(CheckCast.check(ArrayType.SYSTEM_DEFAULT, CharType.SYSTEM_DEFAULT, true));
Assertions.assertTrue(CheckCast.check(ArrayType.SYSTEM_DEFAULT, VarcharType.SYSTEM_DEFAULT, true));
Assertions.assertTrue(CheckCast.check(ArrayType.SYSTEM_DEFAULT, StringType.INSTANCE, true));
Assertions.assertTrue(CheckCast.check(ArrayType.SYSTEM_DEFAULT, JsonType.INSTANCE, true));
Assertions.assertFalse(CheckCast.check(ArrayType.SYSTEM_DEFAULT, VariantType.INSTANCE, false));
Assertions.assertTrue(CheckCast.check(ArrayType.SYSTEM_DEFAULT, VariantType.INSTANCE, true));
Assertions.assertTrue(CheckCast.check(ArrayType.SYSTEM_DEFAULT, ArrayType.SYSTEM_DEFAULT, true));
Assertions.assertFalse(CheckCast.check(ArrayType.SYSTEM_DEFAULT, MapType.SYSTEM_DEFAULT, true));
Assertions.assertFalse(CheckCast.check(ArrayType.SYSTEM_DEFAULT, StructType.SYSTEM_DEFAULT, true));
Expand Down Expand Up @@ -1645,11 +1645,11 @@ public void testCastFromArray() {
Assertions.assertFalse(CheckCast.check(ArrayType.SYSTEM_DEFAULT, TimeV2Type.MAX, false));
Assertions.assertFalse(CheckCast.check(ArrayType.SYSTEM_DEFAULT, IPv4Type.INSTANCE, false));
Assertions.assertFalse(CheckCast.check(ArrayType.SYSTEM_DEFAULT, IPv6Type.INSTANCE, false));
Assertions.assertFalse(CheckCast.check(ArrayType.SYSTEM_DEFAULT, CharType.SYSTEM_DEFAULT, false));
Assertions.assertFalse(CheckCast.check(ArrayType.SYSTEM_DEFAULT, VarcharType.SYSTEM_DEFAULT, false));
Assertions.assertFalse(CheckCast.check(ArrayType.SYSTEM_DEFAULT, StringType.INSTANCE, false));
Assertions.assertTrue(CheckCast.check(ArrayType.SYSTEM_DEFAULT, CharType.SYSTEM_DEFAULT, false));
Assertions.assertTrue(CheckCast.check(ArrayType.SYSTEM_DEFAULT, VarcharType.SYSTEM_DEFAULT, false));
Assertions.assertTrue(CheckCast.check(ArrayType.SYSTEM_DEFAULT, StringType.INSTANCE, false));
Assertions.assertTrue(CheckCast.check(ArrayType.SYSTEM_DEFAULT, JsonType.INSTANCE, false));
Assertions.assertFalse(CheckCast.check(ArrayType.SYSTEM_DEFAULT, VariantType.INSTANCE, false));
Assertions.assertTrue(CheckCast.check(ArrayType.SYSTEM_DEFAULT, VariantType.INSTANCE, false));
Assertions.assertTrue(CheckCast.check(ArrayType.SYSTEM_DEFAULT, ArrayType.SYSTEM_DEFAULT, false));
Assertions.assertFalse(CheckCast.check(ArrayType.SYSTEM_DEFAULT, MapType.SYSTEM_DEFAULT, false));
Assertions.assertFalse(CheckCast.check(ArrayType.SYSTEM_DEFAULT, StructType.SYSTEM_DEFAULT, false));
Expand Down Expand Up @@ -1679,11 +1679,11 @@ public void testCastFromMap() {
Assertions.assertFalse(CheckCast.check(MapType.SYSTEM_DEFAULT, TimeV2Type.MAX, true));
Assertions.assertFalse(CheckCast.check(MapType.SYSTEM_DEFAULT, IPv4Type.INSTANCE, true));
Assertions.assertFalse(CheckCast.check(MapType.SYSTEM_DEFAULT, IPv6Type.INSTANCE, true));
Assertions.assertFalse(CheckCast.check(MapType.SYSTEM_DEFAULT, CharType.SYSTEM_DEFAULT, true));
Assertions.assertFalse(CheckCast.check(MapType.SYSTEM_DEFAULT, VarcharType.SYSTEM_DEFAULT, true));
Assertions.assertFalse(CheckCast.check(MapType.SYSTEM_DEFAULT, StringType.INSTANCE, true));
Assertions.assertTrue(CheckCast.check(MapType.SYSTEM_DEFAULT, CharType.SYSTEM_DEFAULT, true));
Assertions.assertTrue(CheckCast.check(MapType.SYSTEM_DEFAULT, VarcharType.SYSTEM_DEFAULT, true));
Assertions.assertTrue(CheckCast.check(MapType.SYSTEM_DEFAULT, StringType.INSTANCE, true));
Assertions.assertFalse(CheckCast.check(MapType.SYSTEM_DEFAULT, JsonType.INSTANCE, true));
Assertions.assertFalse(CheckCast.check(MapType.SYSTEM_DEFAULT, VariantType.INSTANCE, false));
Assertions.assertTrue(CheckCast.check(MapType.SYSTEM_DEFAULT, VariantType.INSTANCE, true));
Assertions.assertFalse(CheckCast.check(MapType.SYSTEM_DEFAULT, ArrayType.SYSTEM_DEFAULT, true));
Assertions.assertTrue(CheckCast.check(MapType.SYSTEM_DEFAULT, MapType.SYSTEM_DEFAULT, true));
Assertions.assertFalse(CheckCast.check(MapType.SYSTEM_DEFAULT, StructType.SYSTEM_DEFAULT, true));
Expand Down Expand Up @@ -1712,11 +1712,11 @@ public void testCastFromMap() {
Assertions.assertFalse(CheckCast.check(MapType.SYSTEM_DEFAULT, TimeV2Type.MAX, false));
Assertions.assertFalse(CheckCast.check(MapType.SYSTEM_DEFAULT, IPv4Type.INSTANCE, false));
Assertions.assertFalse(CheckCast.check(MapType.SYSTEM_DEFAULT, IPv6Type.INSTANCE, false));
Assertions.assertFalse(CheckCast.check(MapType.SYSTEM_DEFAULT, CharType.SYSTEM_DEFAULT, false));
Assertions.assertFalse(CheckCast.check(MapType.SYSTEM_DEFAULT, VarcharType.SYSTEM_DEFAULT, false));
Assertions.assertFalse(CheckCast.check(MapType.SYSTEM_DEFAULT, StringType.INSTANCE, false));
Assertions.assertTrue(CheckCast.check(MapType.SYSTEM_DEFAULT, CharType.SYSTEM_DEFAULT, false));
Assertions.assertTrue(CheckCast.check(MapType.SYSTEM_DEFAULT, VarcharType.SYSTEM_DEFAULT, false));
Assertions.assertTrue(CheckCast.check(MapType.SYSTEM_DEFAULT, StringType.INSTANCE, false));
Assertions.assertFalse(CheckCast.check(MapType.SYSTEM_DEFAULT, JsonType.INSTANCE, false));
Assertions.assertFalse(CheckCast.check(MapType.SYSTEM_DEFAULT, VariantType.INSTANCE, false));
Assertions.assertTrue(CheckCast.check(MapType.SYSTEM_DEFAULT, VariantType.INSTANCE, false));
Assertions.assertFalse(CheckCast.check(MapType.SYSTEM_DEFAULT, ArrayType.SYSTEM_DEFAULT, false));
Assertions.assertTrue(CheckCast.check(MapType.SYSTEM_DEFAULT, MapType.SYSTEM_DEFAULT, false));
Assertions.assertFalse(CheckCast.check(MapType.SYSTEM_DEFAULT, StructType.SYSTEM_DEFAULT, false));
Expand Down Expand Up @@ -1747,11 +1747,11 @@ public void testCastFromStruct() {
Assertions.assertFalse(CheckCast.check(StructType.SYSTEM_DEFAULT, TimeV2Type.MAX, true));
Assertions.assertFalse(CheckCast.check(StructType.SYSTEM_DEFAULT, IPv4Type.INSTANCE, true));
Assertions.assertFalse(CheckCast.check(StructType.SYSTEM_DEFAULT, IPv6Type.INSTANCE, true));
Assertions.assertFalse(CheckCast.check(StructType.SYSTEM_DEFAULT, CharType.SYSTEM_DEFAULT, true));
Assertions.assertFalse(CheckCast.check(StructType.SYSTEM_DEFAULT, VarcharType.SYSTEM_DEFAULT, true));
Assertions.assertFalse(CheckCast.check(StructType.SYSTEM_DEFAULT, StringType.INSTANCE, true));
Assertions.assertTrue(CheckCast.check(StructType.SYSTEM_DEFAULT, CharType.SYSTEM_DEFAULT, true));
Assertions.assertTrue(CheckCast.check(StructType.SYSTEM_DEFAULT, VarcharType.SYSTEM_DEFAULT, true));
Assertions.assertTrue(CheckCast.check(StructType.SYSTEM_DEFAULT, StringType.INSTANCE, true));
Assertions.assertTrue(CheckCast.check(StructType.SYSTEM_DEFAULT, JsonType.INSTANCE, true));
Assertions.assertFalse(CheckCast.check(StructType.SYSTEM_DEFAULT, VariantType.INSTANCE, true));
Assertions.assertTrue(CheckCast.check(StructType.SYSTEM_DEFAULT, VariantType.INSTANCE, true));
Assertions.assertFalse(CheckCast.check(StructType.SYSTEM_DEFAULT, ArrayType.SYSTEM_DEFAULT, true));
Assertions.assertFalse(CheckCast.check(StructType.SYSTEM_DEFAULT, MapType.SYSTEM_DEFAULT, true));
Assertions.assertTrue(CheckCast.check(StructType.SYSTEM_DEFAULT, StructType.SYSTEM_DEFAULT, true));
Expand Down Expand Up @@ -1795,11 +1795,11 @@ public void testCastFromStruct() {
Assertions.assertFalse(CheckCast.check(StructType.SYSTEM_DEFAULT, TimeV2Type.MAX, false));
Assertions.assertFalse(CheckCast.check(StructType.SYSTEM_DEFAULT, IPv4Type.INSTANCE, false));
Assertions.assertFalse(CheckCast.check(StructType.SYSTEM_DEFAULT, IPv6Type.INSTANCE, false));
Assertions.assertFalse(CheckCast.check(StructType.SYSTEM_DEFAULT, CharType.SYSTEM_DEFAULT, false));
Assertions.assertFalse(CheckCast.check(StructType.SYSTEM_DEFAULT, VarcharType.SYSTEM_DEFAULT, false));
Assertions.assertFalse(CheckCast.check(StructType.SYSTEM_DEFAULT, StringType.INSTANCE, false));
Assertions.assertTrue(CheckCast.check(StructType.SYSTEM_DEFAULT, CharType.SYSTEM_DEFAULT, false));
Assertions.assertTrue(CheckCast.check(StructType.SYSTEM_DEFAULT, VarcharType.SYSTEM_DEFAULT, false));
Assertions.assertTrue(CheckCast.check(StructType.SYSTEM_DEFAULT, StringType.INSTANCE, false));
Assertions.assertTrue(CheckCast.check(StructType.SYSTEM_DEFAULT, JsonType.INSTANCE, false));
Assertions.assertFalse(CheckCast.check(StructType.SYSTEM_DEFAULT, VariantType.INSTANCE, false));
Assertions.assertTrue(CheckCast.check(StructType.SYSTEM_DEFAULT, VariantType.INSTANCE, false));
Assertions.assertFalse(CheckCast.check(StructType.SYSTEM_DEFAULT, ArrayType.SYSTEM_DEFAULT, false));
Assertions.assertFalse(CheckCast.check(StructType.SYSTEM_DEFAULT, MapType.SYSTEM_DEFAULT, false));
Assertions.assertTrue(CheckCast.check(StructType.SYSTEM_DEFAULT, StructType.SYSTEM_DEFAULT, false));
Expand Down
8 changes: 4 additions & 4 deletions regression-test/suites/doc/sql-manual/basic-elements/data-types/array-md.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,10 +81,10 @@ suite("array-md", "p0, nonConcurrent") {
exception "Type exceeds the maximum nesting depth of 9"
}

test {
sql """ SELECT CAST(ARRAY(1, 2, 3) AS STRING) """
exception "can not cast from origin type ARRAY<TINYINT> to target type=TEXT"
}
// test {
// sql """ SELECT CAST(ARRAY(1, 2, 3) AS STRING) """
// exception "can not cast from origin type ARRAY<TINYINT> to target type=TEXT"
// }

qt_sql """ SELECT CAST("[1,2,3]" AS ARRAY<INT>) """

Expand Down
8 changes: 4 additions & 4 deletions regression-test/suites/doc/sql-manual/basic-elements/data-types/map-md.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,10 +150,10 @@ suite("map-md", "p0") {
exception "Type exceeds the maximum nesting depth of 9"
}

test {
sql """ SELECT CAST(MAP('key1', 1, 'key2', 2) AS STRING) """
exception "can not cast from origin type MAP<VARCHAR(4),TINYINT> to target type=TEXT"
}
// test {
// sql """ SELECT CAST(MAP('key1', 1, 'key2', 2) AS STRING) """
// exception "can not cast from origin type MAP<VARCHAR(4),TINYINT> to target type=TEXT"
// }

qt_sql """ SELECT CAST(MAP('key1', 1, 'key2', 2) AS MAP<STRING, STRING>) """

Expand Down
8 changes: 4 additions & 4 deletions regression-test/suites/doc/sql-manual/basic-elements/data-types/struct-md.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,10 +148,10 @@ suite("struct-md", "p0") {
exception "Type exceeds the maximum nesting depth of 9"
}

test {
sql """ SELECT CAST(STRUCT(1, 'John') AS STRING) """
exception "can not cast from origin type STRUCT<StructField ( name=col1, dataType=TINYINT, nullable=true ),StructField ( name=col2, dataType=VARCHAR(4), nullable=true )> to target type=TEXT"
}
// test {
// sql """ SELECT CAST(STRUCT(1, 'John') AS STRING) """
// exception "can not cast from origin type STRUCT<StructField ( name=col1, dataType=TINYINT, nullable=true ),StructField ( name=col2, dataType=VARCHAR(4), nullable=true )> to target type=TEXT"
// }

qt_sql """ SELECT CAST(STRUCT(1, 'John') AS STRUCT<id: INT, name: STRING>) """

Expand Down
36 changes: 18 additions & 18 deletions ...t/suites/query_p0/sql_functions/cast_function/test_cast_array_functions_by_literal.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,24 +67,24 @@ suite("test_cast_array_functions_by_literal") {
exception "errCode = 2,"
}
// ========== cast array to scalar ===========

test {
sql "select cast(['x'] as char)"
// check exception message contains
exception "errCode = 2,"
}

test {
sql "select cast(['x'] as varchar)"
// check exception message contains
exception "errCode = 2,"
}

test {
sql "select cast(['x'] as string)"
// check exception message contains
exception "errCode = 2,"
}
//
// test {
// sql "select cast(['x'] as char)"
// // check exception message contains
// exception "errCode = 2,"
// }
//
// test {
// sql "select cast(['x'] as varchar)"
// // check exception message contains
// exception "errCode = 2,"
// }
//
// test {
// sql "select cast(['x'] as string)"
// // check exception message contains
// exception "errCode = 2,"
// }

test {
sql "select cast([0] as int)"
Expand Down
8 changes: 4 additions & 4 deletions regression-test/suites/query_p0/sql_functions/cast_function/test_cast_struct.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,10 @@ suite("test_cast_struct") {
}

// struct literal can not cast to basic types
test {
sql "select cast({1,2} as string)"
exception "errCode = 2,"
}
// test {
// sql "select cast({1,2} as string)"
// exception "errCode = 2,"
// }

// struct literal cast to struct MUST with same field number
test {
Expand Down
Loading