Skip to content

[fix](cast)Allow cast array, struct and map type to stringlike type. #57326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 26, 2025
Merged

[fix](cast)Allow cast array, struct and map type to stringlike type. #57326

merged 1 commit into from
Oct 26, 2025
+58 −87

Conversation

@Jibing-Li
Copy link
Contributor

What problem does this PR solve?

Allow cast array, struct and map type to stringlike type.

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Jibing-Li
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-DS: Total hot run time: 190050 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit da698696bcf1518079e7091dff8af43add44a32d, data reload: false

query1	1065	451	402	402
query2	6571	1668	1711	1668
query3	6769	218	222	218
query4	26654	24081	22969	22969
query5	5882	666	483	483
query6	352	260	230	230
query7	4660	509	299	299
query8	306	290	295	290
query9	8719	2577	2576	2576
query10	568	352	286	286
query11	15541	15191	14871	14871
query12	187	127	115	115
query13	1710	576	456	456
query14	11794	9174	9179	9174
query15	214	201	173	173
query16	7674	701	532	532
query17	1893	779	635	635
query18	2217	450	384	384
query19	285	211	198	198
query20	165	150	143	143
query21	259	144	124	124
query22	4870	4957	4936	4936
query23	34740	33863	33845	33845
query24	8806	2458	2583	2458
query25	631	554	467	467
query26	1390	299	179	179
query27	3045	525	390	390
query28	4428	2244	2198	2198
query29	826	661	585	585
query30	341	240	198	198
query31	964	869	783	783
query32	81	79	76	76
query33	586	413	350	350
query34	887	899	551	551
query35	861	852	828	828
query36	971	1003	894	894
query37	131	111	80	80
query38	3503	3511	3480	3480
query39	1473	1463	1396	1396
query40	215	130	116	116
query41	59	58	60	58
query42	121	110	115	110
query43	476	492	475	475
query44	1199	740	730	730
query45	189	185	172	172
query46	889	1002	632	632
query47	1725	1789	1704	1704
query48	413	434	340	340
query49	802	499	400	400
query50	644	691	400	400
query51	3884	3847	3866	3847
query52	112	111	103	103
query53	248	269	194	194
query54	599	604	535	535
query55	95	86	83	83
query56	312	311	319	311
query57	1186	1199	1113	1113
query58	277	282	283	282
query59	2513	2670	2491	2491
query60	349	350	329	329
query61	157	152	156	152
query62	828	751	671	671
query63	235	198	200	198
query64	4419	1154	845	845
query65	4031	3973	3930	3930
query66	1036	426	353	353
query67	15490	15329	15070	15070
query68	8336	872	590	590
query69	538	326	290	290
query70	1329	1331	1326	1326
query71	536	347	315	315
query72	5585	4844	4833	4833
query73	667	568	359	359
query74	9189	9074	8809	8809
query75	4137	3392	2822	2822
query76	3819	1156	749	749
query77	805	402	315	315
query78	9492	9911	8961	8961
query79	2184	862	602	602
query80	706	566	502	502
query81	500	262	236	236
query82	434	160	133	133
query83	291	276	251	251
query84	299	109	105	105
query85	891	483	424	424
query86	338	307	313	307
query87	3742	3653	3707	3653
query88	3155	2277	2218	2218
query89	398	323	293	293
query90	2030	219	210	210
query91	168	199	149	149
query92	87	72	66	66
query93	1168	1000	644	644
query94	686	434	343	343
query95	397	324	306	306
query96	496	573	277	277
query97	2952	2955	2870	2870
query98	254	216	217	216
query99	1455	1406	1312	1312
Total cold run time: 281586 ms
Total hot run time: 190050 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 27.52 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit da698696bcf1518079e7091dff8af43add44a32d, data reload: false

query1	0.06	0.05	0.05
query2	0.09	0.05	0.05
query3	0.26	0.08	0.09
query4	1.63	0.13	0.12
query5	0.28	0.27	0.25
query6	1.20	0.66	0.64
query7	0.03	0.03	0.03
query8	0.05	0.04	0.04
query9	0.64	0.52	0.52
query10	0.58	0.58	0.58
query11	0.18	0.11	0.12
query12	0.15	0.12	0.12
query13	0.61	0.60	0.60
query14	1.01	1.02	1.00
query15	0.86	0.84	0.86
query16	0.39	0.40	0.39
query17	1.00	1.02	1.06
query18	0.22	0.20	0.20
query19	1.93	1.79	1.84
query20	0.02	0.01	0.02
query21	15.44	0.17	0.13
query22	5.15	0.08	0.05
query23	15.69	0.27	0.10
query24	2.62	0.71	0.29
query25	0.08	0.07	0.06
query26	0.15	0.14	0.14
query27	0.06	0.06	0.05
query28	4.18	1.15	0.94
query29	12.58	3.97	3.29
query30	0.29	0.13	0.11
query31	2.81	0.59	0.38
query32	3.22	0.54	0.46
query33	3.01	3.06	3.17
query34	15.80	5.16	4.57
query35	4.55	4.60	4.66
query36	0.67	0.51	0.49
query37	0.10	0.06	0.08
query38	0.08	0.05	0.04
query39	0.04	0.03	0.03
query40	0.18	0.15	0.14
query41	0.10	0.03	0.03
query42	0.04	0.03	0.03
query43	0.04	0.04	0.03
Total cold run time: 98.07 s
Total hot run time: 27.52 s

@Jibing-Li
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

ClickBench: Total hot run time: 29.15 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d36997399effaef5a751db5c718788455053a6fa, data reload: false

query1	0.07	0.06	0.06
query2	0.10	0.06	0.06
query3	0.26	0.10	0.10
query4	1.62	0.12	0.13
query5	0.29	0.27	0.28
query6	1.18	0.69	0.68
query7	0.04	0.04	0.03
query8	0.07	0.06	0.05
query9	0.66	0.56	0.57
query10	0.64	0.66	0.63
query11	0.19	0.14	0.14
query12	0.18	0.15	0.14
query13	0.63	0.63	0.61
query14	1.04	1.04	1.05
query15	0.92	0.90	0.88
query16	0.43	0.42	0.42
query17	1.12	1.20	1.17
query18	0.24	0.22	0.24
query19	2.02	1.99	1.87
query20	0.01	0.02	0.01
query21	15.36	0.24	0.15
query22	4.80	0.08	0.05
query23	15.74	0.30	0.12
query24	2.63	0.76	0.43
query25	0.09	0.08	0.07
query26	0.16	0.16	0.15
query27	0.06	0.07	0.06
query28	4.67	1.18	0.97
query29	12.56	4.60	3.82
query30	0.30	0.15	0.13
query31	2.83	0.67	0.42
query32	3.25	0.58	0.48
query33	3.10	3.15	3.11
query34	15.84	5.28	4.58
query35	4.62	4.62	4.62
query36	0.72	0.55	0.52
query37	0.13	0.08	0.08
query38	0.07	0.05	0.04
query39	0.04	0.04	0.03
query40	0.18	0.14	0.15
query41	0.10	0.04	0.04
query42	0.05	0.04	0.03
query43	0.06	0.05	0.05
Total cold run time: 99.07 s
Total hot run time: 29.15 s

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage `` 🎉
Increment coverage report
Complete coverage report

@Jibing-Li
Copy link
Contributor Author

run external

@Jibing-Li
Copy link
Contributor Author

run p0

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 26, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@Jibing-Li Jibing-Li merged commit e7e2b5b into apache:master Oct 26, 2025
27 of 29 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 26, 2025
@Jibing-Li
[fix](cast)Allow cast array, struct and map type to stringlike type. (#…
c14d1eb 
…57326)

Allow cast array, struct and map type to stringlike type.
@github-actions github-actions bot mentioned this pull request Oct 26, 2025
Open
@Jibing-Li Jibing-Li deleted the array branch October 26, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

@zclllyybb zclllyybb zclllyybb approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.x reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Jibing-Li @hello-stephen @doris-robot @yiguolei @zclllyybb