Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cherry-pick](branch-2.0) remove some CHECKs in Tablet::revise_tablet… #36225

Merged
merged 1 commit into from
Jun 13, 2024
Merged

[cherry-pick](branch-2.0) remove some CHECKs in Tablet::revise_tablet… #36225

merged 1 commit into from
Jun 13, 2024

Conversation

zhannngchen
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

cherry-pick #31268

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

Proposed changes

Issue Number: close #xxx

@zhannngchen
[cherry-pick](branch-2.1) remove some CHECKs in Tablet::revise_tablet…
e7728b6 
…_meta (apache#31268) (apache#34702)

## Proposed changes

Issue Number: close #xxx

cherry-pick apache#31268 

## Further comments

If this is a relatively large or complex change, kick off the discussion
at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why
you chose the solution you did and what alternatives you considered,
etc...
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zhannngchen
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.80% (8094/21411)
Line Coverage: 29.47% (66134/224444)
Region Coverage: 28.93% (34088/117810)
Branch Coverage: 24.81% (17499/70546)
Coverage Report: http://coverage.selectdb-in.cc/coverage/e7728b67300bbc6bfbebc8251343a15464325ec9_e7728b67300bbc6bfbebc8251343a15464325ec9/report/index.html

@doris-robot
Copy link

TPC-H: Total hot run time: 49798 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e7728b67300bbc6bfbebc8251343a15464325ec9, data reload: false

------ Round 1 ----------------------------------
q1	17638	4436	4383	4383
q2	2060	155	143	143
q3	10521	1902	1959	1902
q4	10339	1242	1340	1242
q5	8629	3920	3979	3920
q6	232	127	126	126
q7	2044	1625	1600	1600
q8	9534	2734	2708	2708
q9	14388	10683	10386	10386
q10	8645	3506	3523	3506
q11	405	232	249	232
q12	481	304	307	304
q13	18325	3943	4056	3943
q14	350	322	329	322
q15	513	460	449	449
q16	673	576	579	576
q17	1144	971	911	911
q18	7166	6713	6832	6713
q19	1809	1629	1619	1619
q20	566	290	296	290
q21	4458	4160	4083	4083
q22	522	445	440	440
Total cold run time: 120442 ms
Total hot run time: 49798 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4302	4287	4296	4287
q2	319	221	221	221
q3	4198	4146	4168	4146
q4	2737	2740	2727	2727
q5	7228	7143	7141	7141
q6	237	118	118	118
q7	3262	2801	2841	2801
q8	4369	4494	4501	4494
q9	17471	17108	16978	16978
q10	4229	4245	4251	4245
q11	748	684	692	684
q12	1052	871	886	871
q13	6148	3734	3731	3731
q14	464	439	421	421
q15	515	446	454	446
q16	742	669	681	669
q17	3856	3886	3824	3824
q18	8822	8769	8945	8769
q19	1743	1675	1665	1665
q20	2387	2121	2089	2089
q21	8531	8540	8613	8540
q22	1036	938	1016	938
Total cold run time: 84396 ms
Total hot run time: 79805 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 204027 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e7728b67300bbc6bfbebc8251343a15464325ec9, data reload: false

query1	925	426	389	389
query2	6525	2662	2471	2471
query3	6920	211	204	204
query4	21449	18008	17976	17976
query5	19738	6529	6573	6529
query6	290	216	226	216
query7	4158	303	301	301
query8	433	460	432	432
query9	3088	2636	2587	2587
query10	440	297	303	297
query11	11459	10634	10812	10634
query12	124	80	75	75
query13	5600	683	681	681
query14	17870	13370	13779	13370
query15	372	244	253	244
query16	6451	297	267	267
query17	1500	1481	894	894
query18	2259	437	412	412
query19	220	153	153	153
query20	77	77	81	77
query21	196	94	100	94
query22	5351	5099	4989	4989
query23	32463	31984	32009	31984
query24	6871	6568	6535	6535
query25	540	445	421	421
query26	527	167	162	162
query27	1882	293	287	287
query28	6113	2345	2329	2329
query29	2910	2706	2790	2706
query30	241	163	171	163
query31	907	726	739	726
query32	66	67	61	61
query33	411	258	256	256
query34	844	457	484	457
query35	1147	912	940	912
query36	1284	1175	1201	1175
query37	92	60	62	60
query38	3108	2982	2968	2968
query39	1385	1339	1320	1320
query40	212	93	96	93
query41	47	43	45	43
query42	86	92	82	82
query43	817	652	701	652
query44	1119	721	716	716
query45	246	238	239	238
query46	1221	994	968	968
query47	1845	1764	1852	1764
query48	1027	731	713	713
query49	627	374	383	374
query50	886	652	655	652
query51	4815	4659	4669	4659
query52	98	80	86	80
query53	442	324	314	314
query54	2682	2449	2475	2449
query55	95	79	82	79
query56	239	215	211	211
query57	1190	1123	1091	1091
query58	219	202	200	200
query59	4043	3654	4243	3654
query60	216	202	212	202
query61	98	95	96	95
query62	876	448	493	448
query63	486	349	334	334
query64	2417	1548	1459	1459
query65	3616	3550	3584	3550
query66	759	387	382	382
query67	15888	16263	15527	15527
query68	8434	635	644	635
query69	566	354	365	354
query70	1729	1502	1557	1502
query71	413	313	314	313
query72	6575	3519	3508	3508
query73	739	332	322	322
query74	6340	5830	5792	5792
query75	4554	3757	3750	3750
query76	4697	1136	1215	1136
query77	598	246	255	246
query78	12928	11878	12351	11878
query79	8837	648	650	648
query80	1292	391	396	391
query81	509	232	235	232
query82	1574	99	97	97
query83	171	132	135	132
query84	247	71	71	71
query85	1039	321	323	321
query86	356	332	343	332
query87	3200	3009	3013	3009
query88	5097	2326	2339	2326
query89	385	303	277	277
query90	1920	200	204	200
query91	173	140	138	138
query92	63	52	55	52
query93	4868	579	552	552
query94	813	210	204	204
query95	1099	1051	1079	1051
query96	642	322	341	322
query97	6557	6361	6434	6361
query98	183	185	183	183
query99	2852	849	1052	849
Total cold run time: 311998 ms
Total hot run time: 204027 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.88 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e7728b67300bbc6bfbebc8251343a15464325ec9, data reload: false

query1	0.02	0.02	0.02
query2	0.07	0.03	0.02
query3	0.25	0.04	0.05
query4	1.78	0.06	0.06
query5	0.54	0.53	0.53
query6	1.29	0.62	0.61
query7	0.01	0.01	0.01
query8	0.03	0.02	0.02
query9	0.54	0.50	0.48
query10	0.53	0.53	0.52
query11	0.12	0.09	0.09
query12	0.12	0.09	0.09
query13	0.61	0.61	0.62
query14	0.77	0.78	0.80
query15	0.79	0.77	0.76
query16	0.37	0.40	0.38
query17	1.03	1.00	0.99
query18	0.23	0.26	0.22
query19	1.91	1.87	1.80
query20	0.02	0.01	0.01
query21	15.47	0.60	0.55
query22	2.20	2.41	1.81
query23	17.28	0.97	0.85
query24	5.30	1.04	1.08
query25	0.34	0.10	0.05
query26	0.61	0.16	0.17
query27	0.05	0.05	0.04
query28	7.77	0.74	0.72
query29	12.65	2.24	2.35
query30	0.59	0.56	0.53
query31	2.80	0.39	0.38
query32	3.36	0.50	0.50
query33	3.08	3.07	3.14
query34	15.28	4.79	4.82
query35	4.86	4.86	4.85
query36	1.09	1.01	1.02
query37	0.06	0.05	0.05
query38	0.03	0.03	0.02
query39	0.02	0.01	0.02
query40	0.16	0.15	0.13
query41	0.06	0.01	0.02
query42	0.02	0.02	0.01
query43	0.02	0.02	0.02
Total cold run time: 104.13 s
Total hot run time: 30.88 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit e7728b67300bbc6bfbebc8251343a15464325ec9 with default session variables
Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       21.4 seconds inserted 10000000 Rows, about 467K ops/s

@zhannngchen zhannngchen merged commit 9dfb956 into apache:branch-2.0 Jun 13, 2024
22 of 25 checks passed
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
@zhannngchen
[cherry-pick](branch-2.0) remove some CHECKs in Tablet::revise_tablet… (
98fbb42 
apache#36225)

cherry-pick apache#31268
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhannngchen @doris-robot