[fix](merge-on-write) remove some CHECKs in Tablet::revise_tablet_meta #31268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. |
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
zhannngchen
force-pushed
the
fix-clone-core-on-delete-bitmap-calculation
branch
from
b7267d2 to
ca1851d
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
zhannngchen
force-pushed
the
fix-clone-core-on-delete-bitmap-calculation
branch
from
ca1851d to
f60697e
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| DBUG_EXECUTE_IF("Tablet.update_delete_bitmap_without_lock.random_failed", { | ||
| if (rand() % 100 < (100 * dp->param("percent", 0.1))) { | ||
| LOG_WARNING("Tablet.update_delete_bitmap_without_lock.random_failed"); | ||
| Status BaseTablet::update_delete_bitmap_without_lock( |
There was a problem hiding this comment.
warning: method 'update_delete_bitmap_without_lock' can be made static [readability-convert-member-functions-to-static]
Suggested change
| Status BaseTablet::update_delete_bitmap_without_lock( | |
| static Status BaseTablet::update_delete_bitmap_without_lock( |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-DS: Total hot run time: 183936 ms |
|
TeamCity be ut coverage result: |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
zhannngchen
added a commit
to zhannngchen/incubator-doris
that referenced
this pull request
May 11, 2024
ByteYue
pushed a commit
to ByteYue/doris
that referenced
this pull request
May 15, 2024
zhannngchen
added a commit
to zhannngchen/incubator-doris
that referenced
this pull request
Jun 1, 2024
yiguolei
pushed a commit
that referenced
this pull request
Jun 1, 2024
…_meta (#31268) (#34702) ## Proposed changes Issue Number: close #xxx cherry-pick #31268 ## Further comments If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
zhannngchen
added a commit
to zhannngchen/incubator-doris
that referenced
this pull request
Jun 13, 2024
…_meta (apache#31268) (apache#34702) ## Proposed changes Issue Number: close #xxx cherry-pick apache#31268 ## Further comments If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
zhannngchen
added a commit
that referenced
this pull request
Jun 13, 2024
dataroaring
pushed a commit
that referenced
this pull request
Jul 2, 2024
…ur (#37001) ## Proposed changes Issue Number: close #xxx introduced by #31268 full clone failure may produce duplicate keys in mow table the bug would be triggered in the following condition: 1. replica 0 miss version 2. replica 0 try to do full clone from other replicas 3. the full clone failed and the delete bitmap is overrided incorrectly 4. replica 0 try to do incremental clone again and this time the clone succeed 5. incremental clone can't fix the delete bitmap overrided by previous failed full clone 6. duplicate key occurred solution: for full clone, don't override the delete bitmap, use `merge()` method instead.
dataroaring
pushed a commit
that referenced
this pull request
Jul 2, 2024
…ur (#37001) ## Proposed changes Issue Number: close #xxx introduced by #31268 full clone failure may produce duplicate keys in mow table the bug would be triggered in the following condition: 1. replica 0 miss version 2. replica 0 try to do full clone from other replicas 3. the full clone failed and the delete bitmap is overrided incorrectly 4. replica 0 try to do incremental clone again and this time the clone succeed 5. incremental clone can't fix the delete bitmap overrided by previous failed full clone 6. duplicate key occurred solution: for full clone, don't override the delete bitmap, use `merge()` method instead.
zhannngchen
added a commit
to zhannngchen/incubator-doris
that referenced
this pull request
Jul 3, 2024
…ur (apache#37001) ## Proposed changes Issue Number: close #xxx introduced by apache#31268 full clone failure may produce duplicate keys in mow table the bug would be triggered in the following condition: 1. replica 0 miss version 2. replica 0 try to do full clone from other replicas 3. the full clone failed and the delete bitmap is overrided incorrectly 4. replica 0 try to do incremental clone again and this time the clone succeed 5. incremental clone can't fix the delete bitmap overrided by previous failed full clone 6. duplicate key occurred solution: for full clone, don't override the delete bitmap, use `merge()` method instead.
zhannngchen
added a commit
to zhannngchen/incubator-doris
that referenced
this pull request
Jul 3, 2024
…ur (apache#37001) ## Proposed changes Issue Number: close #xxx introduced by apache#31268 full clone failure may produce duplicate keys in mow table the bug would be triggered in the following condition: 1. replica 0 miss version 2. replica 0 try to do full clone from other replicas 3. the full clone failed and the delete bitmap is overrided incorrectly 4. replica 0 try to do incremental clone again and this time the clone succeed 5. incremental clone can't fix the delete bitmap overrided by previous failed full clone 6. duplicate key occurred solution: for full clone, don't override the delete bitmap, use `merge()` method instead.
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...