Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](date) fix the value may be changed during the parsing of date and datetime types #11573

Merged
merged 3 commits into from
Aug 8, 2022
Merged

[fix](date) fix the value may be changed during the parsing of date and datetime types #11573

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e0329c3
[fix](date) fix the value may be changed during the parsing of date a…
luozenglin Aug 6, 2022
04b7815
add some comments
luozenglin Aug 7, 2022
aa91dc2
add fe ut
luozenglin Aug 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion fe/fe-core/src/main/java/org/apache/doris/analysis/DateLiteral.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@
import java.time.format.DateTimeFormatter;
import java.time.format.DateTimeFormatterBuilder;
import java.time.format.DateTimeParseException;
import java.time.format.ResolverStyle;
import java.time.format.TextStyle;
import java.time.temporal.ChronoField;
import java.time.temporal.TemporalAccessor;
Expand Down Expand Up @@ -415,7 +416,9 @@ private void init(String s, Type type) throws AnalysisException {
builder.appendLiteral(":");
}
}
DateTimeFormatter formatter = builder.toFormatter();
// The default resolver style is 'SMART', which parses "2022-06-31" as "2022-06-30"
// and does not throw an exception. 'STRICT' is used here.
DateTimeFormatter formatter = builder.toFormatter().withResolverStyle(ResolverStyle.STRICT);
dateTime = formatter.parse(s);
parsed = true;
}
Expand Down