Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](date) fix the value may be changed during the parsing of date and datetime types #11573

Merged
merged 3 commits into from
Aug 8, 2022
Merged

[fix](date) fix the value may be changed during the parsing of date and datetime types #11573

merged 3 commits into from
Aug 8, 2022

Conversation

luozenglin
Copy link
Contributor

Proposed changes

Issue Number: close #11572

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added the area/planner Issues or PRs related to the query planner label Aug 6, 2022
Gabriel39
Gabriel39 previously approved these changes Aug 7, 2022
View reviewed changes
Copy link
Contributor

@Gabriel39 Gabriel39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2022

PR approved by anyone and no changes requested.

@Gabriel39
Copy link
Contributor

Could you add a case in FE UT?

@luozenglin
Copy link
Contributor Author

Could you add a case in FE UT?

done

yiguolei
yiguolei approved these changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit 4f5db35 into apache:master Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiguolei yiguolei yiguolei approved these changes

@Gabriel39 Gabriel39 Gabriel39 left review comments

Assignees
No one assigned
Labels
area/planner Issues or PRs related to the query planner reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] the value may be changed of date and datetime types
3 participants
@luozenglin @Gabriel39 @yiguolei