Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

complie failed when using direct compilation #1862

Closed
yangzhg opened this issue Sep 24, 2019 · 3 comments
Closed

complie failed when using direct compilation #1862

yangzhg opened this issue Sep 24, 2019 · 3 comments
Labels
kind/fix Categorizes issue or PR as related to a bug.
Milestone
0.11

Comments

@yangzhg
Copy link
Member

yangzhg commented Sep 24, 2019

complie failed when using direct compilation in ubuntu 16.04 according to https://doris.apache.org/documentation/cn/installing/compilation.html#centos-ubuntu
because of:

  1. the minimum version of gcc is 7.3.0 not 5.3.1
  2. the minimum version of cmake is 3.11 not 3.4.3+（building arrow from source requires 3.11 or higher）
  3. thirdparty lib libarrow.a and libparquet.a shoud in lib64 not lib dir
@imay
Copy link
Contributor

imay commented Sep 24, 2019

complie failed when using direct compilation in ubuntu 16.04 according to https://doris.apache.org/documentation/cn/installing/compilation.html#centos-ubuntu
because of:

  1. the minimum version of gcc is 7.3.0 not 5.3.1

what's the problem compiling with GCC 5.3.1

  1. the minimum version of cmake is 3.11 not 3.4.3+（building arrow from source requires 3.11 or higher）
  2. thirdparty lib libarrow.a and libparquet.a shoud in lib64 not lib dir

@imay imay added this to the 0.11 milestone Sep 25, 2019
@imay imay added the kind/fix Categorizes issue or PR as related to a bug. label Sep 25, 2019
@imay
Copy link
Contributor

imay commented Sep 25, 2019

This will affect users using Doris, I think we should close this before we release 0.11.0. @yangzhg can you please give us a PR to fix it ASAP?

@yangzhg
Copy link
Member Author

yangzhg commented Sep 25, 2019 •
edited
Loading

finally i found the reason of why cannot complie in gcc5. becaue of c++11 can't use enum class as unordered_map key, ref https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60970 .
This was considered a defect in the standard, and was fixed in C++14: http://www.open-std.org/jtc1/sc22/wg21/docs/lwg-defects.html#2148
so it need to provide a specialization of std::hash before C++14
I will fix it today

imay pushed a commit that referenced this issue Sep 26, 2019
@yangzhg @imay
Fix direct compilation failed #1862 (#1875)
5d1165f 
Fix direct compilation failed：

fix compile thirdparty in ubuntu will install libs to lib dir instead of lib64
fix compile error in gcc5 due to the defect of c++11 (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60970)
fix gcc version check will not work on some OS
@imay imay closed this as completed Sep 26, 2019
SWJTU-ZhangLei pushed a commit to SWJTU-ZhangLei/incubator-doris that referenced this issue Jul 25, 2023
@zddr
(selectdb-cloud) User master side provided IP of BE (apache#1862)
31bc4c3 
When FE is deployed on a virtual machine and CN is deployed on k8s, FE needs to use a proxy IP to communicate with CN nodes, and BE cannot resolve the proxy IP from the local network card. We change the previous verification rules and obey the IP assigned by the master

merge from:apache#19951
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/fix Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
0.11
Development

No branches or pull requests
2 participants
@imay @yangzhg