Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Add token as authentication for python gateway #12893

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

zhongjiajie
Copy link
Member

separate from #6407. Authentication, add secret to ensure only trusted people could connect to gateway.

fix: #8255

separate from apache#6407. Authentication, add secret to ensure only trusted people could connect to gateway.

fix: apache#8255
@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2022

Codecov Report

Merging #12893 (eced157) into dev (d324cce) will increase coverage by 0.02%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                dev   #12893      +/-   ##
============================================
+ Coverage     39.41%   39.43%   +0.02%     
+ Complexity     4245     4242       -3     
============================================
  Files          1053     1052       -1     
  Lines         39880    39860      -20     
  Branches       4585     4586       +1     
============================================
+ Hits          15718    15719       +1     
+ Misses        22384    22365      -19     
+ Partials       1778     1776       -2     
Impacted Files Coverage Δ
...che/dolphinscheduler/api/python/PythonGateway.java 17.93% <0.00%> (-0.17%) ⬇️
...org/apache/dolphinscheduler/remote/utils/Host.java 42.55% <0.00%> (-2.13%) ⬇️
...e/dolphinscheduler/remote/NettyRemotingClient.java 51.38% <0.00%> (-1.39%) ⬇️
.../api/configuration/PythonGatewayConfiguration.java
...erver/master/processor/queue/TaskEventService.java 80.35% <0.00%> (+10.71%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Nov 14, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

14.3% 14.3% Coverage
0.0% 0.0% Duplication

@zhongjiajie zhongjiajie merged commit 6d8befa into apache:dev Nov 14, 2022
@zhongjiajie zhongjiajie deleted the b-py-conn-token branch November 14, 2022 10:43
zhongjiajie added a commit that referenced this pull request Nov 28, 2022
separate from #6407. Authentication, add secret to ensure only trusted people could connect to gateway.

fix: #8255

(cherry picked from commit 6d8befa)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2.0 for 3.2.0 version backend bug Something isn't working Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][python] Add authentication for python gateway server
3 participants