Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Add token as authentication for python gateway #13

Merged
merged 6 commits into from
Nov 15, 2022

Conversation

zhongjiajie
Copy link
Member

@zhongjiajie zhongjiajie commented Nov 14, 2022

Brief Summary of The Change

separate from apache/dolphinscheduler#6407. Authentication, add secret to ensure only trusted people could
connect to gateway.

fix: apache/dolphinscheduler#8255
ref: apache/dolphinscheduler#12893

Pull Request checklist

I confirm that the following checklist has been completed.

  • Add/Change test cases for the changes.
  • Add/Change the related documentation.
  • (Optional) Add your change to UPDATING.md when it is an incompatible change.

@zhongjiajie zhongjiajie marked this pull request as ready for review November 14, 2022 10:20
@zhongjiajie zhongjiajie self-assigned this Nov 14, 2022
@zhongjiajie zhongjiajie added enhancement New feature or request dep-main-repo Dependent on repository apache/dolphinscheduler labels Nov 14, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2022

Codecov Report

Merging #13 (74332e5) into main (20b2a2b) will decrease coverage by 0.00%.
The diff coverage is 90.00%.

@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
- Coverage   90.60%   90.59%   -0.01%     
==========================================
  Files          56       56              
  Lines        2032     2042      +10     
==========================================
+ Hits         1841     1850       +9     
- Misses        191      192       +1     
Flag Coverage Δ
unittests 90.59% <90.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pydolphinscheduler/configuration.py 97.01% <90.00%> (-1.24%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@jieguangzhou jieguangzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhongjiajie zhongjiajie merged commit 0b7c0be into apache:main Nov 15, 2022
@zhongjiajie zhongjiajie deleted the f-auth-token branch November 15, 2022 08:07
@zhongjiajie
Copy link
Member Author

Brief Summary of The Change

separate from apache/dolphinscheduler#6407. Authentication, add secret to ensure only trusted people could connect to gateway.

fix: apache/dolphinscheduler#8255 ref: apache/dolphinscheduler#12893

Pull Request checklist

I confirm that the following checklist has been completed.

  • Add/Change test cases for the changes.
  • Add/Change the related documentation.
  • (Optional) Add your change to UPDATING.md when it is an incompatible change.

released after apache/dolphinscheduler:3.1.2

@zhongjiajie zhongjiajie removed the dep-main-repo Dependent on repository apache/dolphinscheduler label Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][python] Add authentication for python gateway server
3 participants