Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve partition boundaries #505

Merged
merged 13 commits into from
Feb 15, 2024
Merged

Improve partition boundaries #505

merged 13 commits into from
Feb 15, 2024

Commits on Feb 4, 2024

  1. Minor changes to BoundsRule

    @leerho
    leerho committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    bae6ab5 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2024

  1. Primary changes (so far) are to 

    ItemsSketchSortedView::getPartitionBoundaries(..).

This change dramatically improved the handling of the end points and
isolates this adjustment from the SortedView class members.

The changes to SortedViewIterator and GenericSortedViewIterator are to
add some functionality of getting the key iteration variables without
having to specify the sorting criteria.

Added a specific test to check the upper and lower boundary adjustments
of a partition.
    @leerho
    leerho committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    cc77ef0 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'minor_changes_to_boundsRule' into improve_partition_bou… 

    …ndaries
    @leerho
    leerho committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    2a71af4 View commit details
    Browse the repository at this point in the history

  3. Turned printing off.

    @leerho
    leerho committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    4b652d5 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2024

  1. Improve ItemsSketch.toString(summary) printout.

    @leerho
    leerho committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    1bd6adb View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2024

  1. This fixes a bug discovered in recent Druid testing. 

    Makes other improvements to the getPartionBoundaries code.
    @leerho
    leerho committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    3a9402a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into improve_partition_boundaries

    @leerho
    leerho committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    d0ae2b3 View commit details
    Browse the repository at this point in the history

  3. Corrected a CodeQL issue.

    @leerho
    leerho committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    2f664de View commit details
    Browse the repository at this point in the history

  4. Trying to correct EBPPS test

    @leerho
    leerho committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    cd3989a View commit details
    Browse the repository at this point in the history

  5. Disabling that EBPPS test, which has nothing to do with this PR.

    @leerho
    leerho committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    e3403f7 View commit details
    Browse the repository at this point in the history

  6. Restored original "deserializeTooShort" test, with the exception of 

    changing the last line to use ArrayOfLongsSerDe() instead.
    @leerho
    leerho committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    dedb5e8 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2024

  1. Added comments to ItemsSketchSortedView::getPartitionBoundaries(..)

    @leerho
    leerho committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    eeb4f53 View commit details
    Browse the repository at this point in the history

  2. Forgot to remove the now unused imports.

    @leerho
    leerho committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    cfedb14 View commit details
    Browse the repository at this point in the history