Improve partition boundaries #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ItemsSketchSortedView::getPartitionBoundaries(..). This change dramatically improved the handling of the end points and isolates this adjustment from the SortedView class members. The changes to SortedViewIterator and GenericSortedViewIterator are to add some functionality of getting the key iteration variables without having to specify the sorting criteria. Added a specific test to check the upper and lower boundary adjustments of a partition.
Makes other improvements to the getPartionBoundaries code.
changing the last line to use ArrayOfLongsSerDe() instead.
jmalkin
approved these changes
Feb 14, 2024
| adjLen += adjLow ? 1 : 0; | ||
| adjLen += adjHigh ? 1 : 0; | ||
|
|
||
| final T[] adjQuantiles; |
There was a problem hiding this comment.
This is the start of a long code block with no indication of what it's doing. It'd be useful to have a little description of what's going on here.
There was a problem hiding this comment.
Good feedback. Will do.
|
|
||
| import java.util.ArrayList; | ||
| import java.util.Arrays; |
There was a problem hiding this comment.
This is probably extraneous?
There was a problem hiding this comment.
Yes, and so is: import static org.testng.Assert.fail;
I will fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug discovered in recent Druid testing.
Makes other improvements to the getPartionBoundaries code.