Merged
Conversation
alamb
commented
Aug 23, 2021
| BinaryOperator::Multiply => Ok(Operator::Multiply), | ||
| BinaryOperator::Divide => Ok(Operator::Divide), | ||
| BinaryOperator::Modulus => Ok(Operator::Modulus), | ||
| BinaryOperator::Modulo => Ok(Operator::Modulo), |
Contributor
Author
There was a problem hiding this comment.
sqlparser renamed this to Modulo as that is a more correct name for the remainder function. I did the same for DataFusion, though we can leave Operator::Modulus if that is desired
Contributor
There was a problem hiding this comment.
Seems to me like it is worth fixing everywhere consistently
alamb
commented
Aug 23, 2021
|
|
||
| SQLExpr::Trim { expr, trim_where } => { | ||
| let fun = match trim_where { | ||
| Some((trim_where, _expr)) => { |
Contributor
Author
There was a problem hiding this comment.
Filed #935 to track supporting this extended syntax
Dandandan
approved these changes
Aug 23, 2021
houqp
approved these changes
Aug 24, 2021
houqp
reviewed
Aug 24, 2021
andygrove
approved these changes
Aug 24, 2021
Contributor
Author
|
FYI @b41sh |
unkloud
pushed a commit
to unkloud/datafusion
that referenced
this pull request
Mar 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
related to #795
Rationale for this change
Get SQL support for regular expression matching added by @b41sh in apache/datafusion-sqlparser-rs#328, thus unblocking #870.
What changes are included in this PR?
Operator::ModulustoOperator::Moduloto match change in SQL in Fix the term 'Modulus' to 'Modulo' datafusion-sqlparser-rs#335Are there any user-facing changes?
Operator::Modulus-->Operator::Modulo