Add support for PostgreSQL regex match#328
Add support for PostgreSQL regex match#328alamb merged 6 commits intoapache:mainfrom b41sh:regexp_match
Conversation
|
cc @Dandandan / @andygrove |
Pull Request Test Coverage Report for Build 1141922167Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
alamb
left a comment
There was a problem hiding this comment.
This looks great @b41sh -- FYI I pulled your code down locally to play around with it and tried to fix the clippy errors on CI while I was at it, in case that is helpful to you: https://github.com/b41sh/sqlparser-rs/pull/1
| Token::Whitespace(Whitespace::Space), | ||
| Token::SingleQuotedString("^a".into()), | ||
| ]; | ||
| compare(expected, tokens); |
Fix clippy in regexp_match branch
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
@alamb Thanks for your help. But I have a question, why I run |
@b41sh I don't honestly know / understand. I also had trouble getting clippy to report all errors locally for me until I switched to running it like this find . -name '*.rs' | grep -v target | xargs touch && cargo clippy --all --all-targets -- -D warningsWhile not ideal (it forces a recheck), it does work reliably for me |
ok, I will try it |
Support PostgreSQL regular expression matching syntax as described in the Postgres manual: https://www.postgresql.org/docs/9.3/functions-matching.html
used by arrow-datafusion#795