Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: Add comments about initial value for BitAnd accumulator #6964

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Minor: Add comments about initial value for BitAnd accumulator #6964

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions datafusion/physical-expr/src/aggregate/bit_and_or_xor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,6 +278,9 @@ impl AggregateExpr for BitAnd {

fn create_groups_accumulator(&self) -> Result<Box<dyn GroupsAccumulator>> {
use std::ops::BitAndAssign;
// Note the default value for BitAnd should be all set
// (e.g. `0b11...111`) use MAX / -1 here to get appropriate
// bit pattern for each type
match self.data_type {
DataType::Int8 => {
instantiate_accumulator!(self, -1, Int8Type, |x, y| x.bitand_assign(y))
Expand Down