Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Add comments about initial value for BitAnd accumulator #6964

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jul 13, 2023

Which issue does this PR close?

Follow on to #6957

Rationale for this change

I didn't see a comment from @viirya #6957 (comment) that had the good suggestion to explain the default value

What changes are included in this PR?

Add doc comments to explain the code

Are these changes tested?

N/A

Are there any user-facing changes?

Copy link
Member

@viirya viirya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @alamb 👍

@Dandandan Dandandan merged commit 06c33cf into apache:main Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
physical-expr Physical Expressions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants