-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[parquet] Avoid read parquet index when there is no filter pushdown. #6317
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,6 +23,7 @@ use datafusion::datasource::listing::PartitionedFile; | |
use datafusion::datasource::object_store::ObjectStoreUrl; | ||
use datafusion::execution::context::SessionState; | ||
use datafusion::physical_plan::file_format::{FileScanConfig, ParquetExec}; | ||
use datafusion::physical_plan::metrics::MetricValue; | ||
use datafusion::physical_plan::ExecutionPlan; | ||
use datafusion::prelude::SessionContext; | ||
use datafusion_common::{ScalarValue, Statistics, ToDFSchema}; | ||
|
@@ -714,3 +715,41 @@ async fn prune_decimal_in_list() { | |
) | ||
.await; | ||
} | ||
|
||
#[tokio::test] | ||
async fn without_pushdown_filter() { | ||
let mut context = ContextWithParquet::new(Scenario::Timestamps, Page).await; | ||
|
||
let output1 = context.query("SELECT * FROM t").await; | ||
|
||
let mut context = ContextWithParquet::new(Scenario::Timestamps, Page).await; | ||
|
||
let output2 = context | ||
.query("SELECT * FROM t where nanos < to_timestamp('2023-01-02 01:01:11Z')") | ||
.await; | ||
|
||
let bytes_scanned_without_filter = cast_count_metric( | ||
output1 | ||
.parquet_metrics | ||
.sum_by_name("bytes_scanned") | ||
.unwrap(), | ||
) | ||
.unwrap(); | ||
let bytes_scanned_with_filter = cast_count_metric( | ||
output2 | ||
.parquet_metrics | ||
.sum_by_name("bytes_scanned") | ||
.unwrap(), | ||
) | ||
.unwrap(); | ||
|
||
// Without filter will not read pageIndex. | ||
assert!(bytes_scanned_with_filter > bytes_scanned_without_filter); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nice test |
||
} | ||
|
||
fn cast_count_metric(metric: MetricValue) -> Option<usize> { | ||
match metric { | ||
MetricValue::Count { count, .. } => Some(count.value()), | ||
_ => None, | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the use of this code, I think using
is_empty()
rather thanlen()
would be clearerThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think need the number of filters in future 😆