[parquet] Avoid read parquet index when there is no filter pushdown. #6317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
reviewed
May 10, 2023
There was a problem hiding this comment.
Thanks @Ted-Jiang -- this is looking good. I think we should remove the unwrap to avoid panics but otherwise I think this is looking good
| @@ -222,6 +222,11 @@ impl PagePruningPredicate { | |||
| file_metrics.page_index_rows_filtered.add(total_skip); | |||
| Ok(Some(final_selection)) | |||
| } | |||
|
|
|||
| /// Returns the number of filters in the [`PagePruningPredicate`] | |||
| pub fn filter_number(&self) -> usize { | |||
There was a problem hiding this comment.
Given the use of this code, I think using is_empty() rather than len() would be clearer
There was a problem hiding this comment.
I think need the number of filters in future 😆
| .unwrap(); | ||
|
|
||
| // Without filter will not read pageIndex. | ||
| assert!(bytes_scanned_with_filter > bytes_scanned_without_filter); |
alamb
reviewed
May 10, 2023
There was a problem hiding this comment.
Thanks @Ted-Jiang -- this is looking good. I think we should remove the unwrap to avoid panics but otherwise I think this is looking good
github-actions
bot
added
logical-expr
github-actions
bot
removed
logical-expr
alamb
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6315
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?