-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Enable codecov #6067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable codecov #6067
Conversation
- uses: actions/checkout@v3 | ||
with: | ||
submodules: true | ||
# `cargo tarpaulin` requires lots of disk space |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change1: rm large unnecessary files
rustup toolchain install stable | ||
rustup default stable | ||
cargo install --version 0.20.1 cargo-tarpaulin | ||
# Disable failing tests temporarily |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change2: skipped failing test cases temporarily
Codecov Report
@@ Coverage Diff @@
## main #6067 +/- ##
=======================================
Coverage ? 77.56%
=======================================
Files ? 419
Lines ? 96984
Branches ? 0
=======================================
Hits ? 75228
Misses ? 21756
Partials ? 0 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Just in my opinion, I don't feel the need to add codedev for Datafusion for now. |
I followed |
The coverage report from this PR is here https://app.codecov.io/gh/apache/arrow-datafusion/pull/6067 but contains no information on what was not covered (so like what do we get from this site other than a webpage with a number). When I look at the coverage report from arrow2, it seems to be quite useful (and have sources, etc): Maybe we can follow the model there https://github.com/jorgecarleitao/arrow2/blob/main/.github/workflows/coverage.yml 🤔 |
Detailed information is normally displayed when switching to commit instead of pull requests. |
It is possible. However, if you look at codecov reports from sqlparser (which I think is configured the same as this), such as the one on apache/datafusion-sqlparser-rs#817 https://coveralls.io/builds/57556726 it has the same lack of source issue |
Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days. |
Which issue does this PR close?
Issue #3678
Prev PR that disabled codecov: #3679
Rationale for this change
cargo tarpaulin
will consume lots of disk space, previously it failed due to this reason. I tried removing several large files on GitHub Action virtual machines, then It can run again.Problem: after that, two dataframe tests failed, they're disabled temporarily. (
cargo tarpaulin
will run tests to collect coverage stats, these tests will only fail undercargo tarpaulin
, normal test runs are not affected)https://github.com/apache/arrow-datafusion/blob/10b0eff7dfbe195a724285bc166b20240e8ebccb/datafusion/core/src/dataframe.rs#L1978
https://github.com/apache/arrow-datafusion/blob/10b0eff7dfbe195a724285bc166b20240e8ebccb/datafusion/core/src/dataframe.rs#L2070
These two test cases are added after last time codecov CI is disabled, I don't know why they might fail under
cargo tarpaulin
Failure messages:
Failing CI run : https://github.com/2010YOUY01/arrow-datafusion/actions/runs/4750006102
Can be reproduced with CI config in this commit 75c7fb7
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?