feat: bigquery struct literal #817
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
togami2864
force-pushed
the
feat/struct-literal-bq
branch
from
0cf0dc0 to
280ddef
Compare
Pull Request Test Coverage Report for Build 4341768952
💛 - Coveralls |
togami2864
force-pushed
the
feat/struct-literal-bq
branch
from
280ddef to
0d9c5e8
Compare
togami2864
force-pushed
the
feat/struct-literal-bq
branch
from
c8dc171 to
c6610ea
Compare
togami2864
commented
Mar 6, 2023
Comment on lines
+433
to
+440
| // TODO: support "ARRAY in STRUCT", "STRUCT in STRUCT" | ||
| // let sql = r#"SELECT STRUCT<STRUCT<STRING>>(STRUCT("foo"))"#; | ||
| // let select = bigquery().verified_only_select(sql); | ||
| // assert_eq!(1, select.projection.len()); | ||
|
|
||
| // let sql = r#"SELECT STRUCT<ARRAY<STRING>>(["foo"])"#; | ||
| // let select = bigquery().verified_only_select(sql); | ||
| // assert_eq!(1, select.projection.len()); |
There was a problem hiding this comment.
I want to postpone this. I have no idea to parse this now because Lexer treats ">>" as shiftleft.
There was a problem hiding this comment.
@togami2864 I think I may have misunderstood your intent -- do you want to postpone the entire PR or just this portion of the syntax?
togami2864
changed the title
|
This PR seems like it waiting for time to respond to feedback, so marking it as a draft |
iffyio
added a commit
to validio-io/sqlparser-rs
that referenced
this pull request
Oct 15, 2023
This builds on top of apache#817 - `STRUCT` literal support via `STRUCT` keyword https://cloud.google.com/bigquery/docs/reference/standard-sql/data-types#constructing_a_struct - `STRUCT` and `ARRAY` type declarations https://cloud.google.com/bigquery/docs/reference/standard-sql/data-types#declaring_an_array_type https://cloud.google.com/bigquery/docs/reference/standard-sql/data-types#declaring_a_struct_type It works around the issue of not being able to parse nested types like `ARRAY<ARRAY<INT>>` due to the right angle bracket ambiguity where the tokenizer chooses the right-shift operator (this affects other dialects like Hive that have similar syntax). When parsing such types, we accept a closing `>` or `>>` and track which variant is in use in order to preserve correctness. Fixes apache#901 Closes apache#817
iffyio
added a commit
to validio-io/sqlparser-rs
that referenced
this pull request
Oct 15, 2023
This builds on top of apache#817 - `STRUCT` literal support via `STRUCT` keyword https://cloud.google.com/bigquery/docs/reference/standard-sql/data-types#constructing_a_struct - `STRUCT` and `ARRAY` type declarations https://cloud.google.com/bigquery/docs/reference/standard-sql/data-types#declaring_an_array_type https://cloud.google.com/bigquery/docs/reference/standard-sql/data-types#declaring_a_struct_type It works around the issue of not being able to parse nested types like `ARRAY<ARRAY<INT>>` due to the right angle bracket ambiguity where the tokenizer chooses the right-shift operator (this affects other dialects like Hive that have similar syntax). When parsing such types, we accept a closing `>` or `>>` and track which variant is in use in order to preserve correctness. Fixes apache#901 Closes apache#817
iffyio
added a commit
to validio-io/sqlparser-rs
that referenced
this pull request
Oct 15, 2023
This builds on top of apache#817 - `STRUCT` literal support via `STRUCT` keyword https://cloud.google.com/bigquery/docs/reference/standard-sql/data-types#constructing_a_struct - `STRUCT` and `ARRAY` type declarations https://cloud.google.com/bigquery/docs/reference/standard-sql/data-types#declaring_an_array_type https://cloud.google.com/bigquery/docs/reference/standard-sql/data-types#declaring_a_struct_type It works around the issue of not being able to parse nested types like `ARRAY<ARRAY<INT>>` due to the right angle bracket ambiguity where the tokenizer chooses the right-shift operator (this affects other dialects like Hive that have similar syntax). When parsing such types, we accept a closing `>` or `>>` and track which variant is in use in order to preserve correctness. Fixes apache#901 Closes apache#817
iffyio
added a commit
to validio-io/sqlparser-rs
that referenced
this pull request
Oct 15, 2023
This builds on top of apache#817 - `STRUCT` literal support via `STRUCT` keyword https://cloud.google.com/bigquery/docs/reference/standard-sql/data-types#constructing_a_struct - `STRUCT` and `ARRAY` type declarations https://cloud.google.com/bigquery/docs/reference/standard-sql/data-types#declaring_an_array_type https://cloud.google.com/bigquery/docs/reference/standard-sql/data-types#declaring_a_struct_type It works around the issue of not being able to parse nested types like `ARRAY<ARRAY<INT>>` due to the right angle bracket ambiguity where the tokenizer chooses the right-shift operator (this affects other dialects like Hive that have similar syntax). When parsing such types, we accept a closing `>` or `>>` and track which variant is in use in order to preserve correctness. Fixes apache#901 Closes apache#817
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support big query struct literal. https://cloud.google.com/bigquery/docs/reference/standard-sql/lexical#struct_literals
This PR includes
Define keywords for struct types
Support three types of struct litral
tuple syntax
typeless struct syntax
typed struct syntax