Closed
Conversation
alamb
force-pushed
the
alamb/remove_cast_column2
branch
from
c135d32 to
b2e105b
Compare
This was referenced Dec 5, 2025
Contributor
Author
|
This is infact used, so let's close this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This is an alternative to
CastColumnExprwithCastColumn#19097Rationale for this change
@kosiew added struct aware casting in the following PR
CastColumnExprfor struct-aware column casting #17773However, that relies on a new physical
CastColumnExprthat has a non trivial redundancy withCastExprand is not connected anywhereWhat changes are included in this PR?
CastColumnExprAre these changes tested?
Yes by CI
Are there any user-facing changes?
No