Consolidate CastColumnExpr with CastColumn #19097
Draft
alamb wants to merge 1 commit intoapache:mainfrom
Draft
Conversation
github-actions
bot
added
physical-expr
Contributor
Author
|
I need to review this code a little more but I think it is looking pretty good |
alamb
commented
Dec 5, 2025
This was referenced Dec 5, 2025
alamb
force-pushed
the
alamb/remove_cast_column
branch
from
9fd6490 to
5ef668c
Compare
alamb
force-pushed
the
alamb/remove_cast_column
branch
from
5ef668c to
3935ba5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
@kosiew added struct aware casting in the following PR
CastColumnExprfor struct-aware column casting #17773However, that relies on a new physical
CastColumnExprthat has a non trivial redundancy withCastExpr.Instead of relying on the new PhysicalExpr, I we should upgrade
CastExprto handle both normal and struct castingWhat changes are included in this PR?
CastColumnExprwithCastColumnCastColumnExprI had codex do the first version for me, and it did quite a nice job
Are these changes tested?
Yes by CI
Are there any user-facing changes?
No