fix: NaN semantics in GROUP BY #16256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sqllogictest
This was referenced Jun 5, 2025
andygrove
reviewed
Jun 5, 2025
| } | ||
|
|
||
| *equal_to_result = self.group_values[lhs_row] == array.value(rhs_row); | ||
| *equal_to_result = self.group_values[lhs_row].is_eq(array.value(rhs_row)); |
There was a problem hiding this comment.
The implementation of is_eq for floating point is self.to_bits() == rhs.to_bits()
kosiew
pushed a commit
to kosiew/datafusion
that referenced
this pull request
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
NaN != NaN
What changes are included in this PR?
Use arrow is_eq to test equality
Are these changes tested?
UT
Are there any user-facing changes?
No