chore: Update documentation and ignore Spark SQL tests for known issue with count distinct on NaN in aggregate #1847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
commented
Jun 4, 2025
Comment on lines
-32
to
-37
| # Compatibility Guide | ||
|
|
||
| Comet aims to provide consistent results with the version of Apache Spark that is being used. | ||
|
|
||
| This guide offers information about areas of functionality where there are known differences. | ||
|
|
There was a problem hiding this comment.
Thsi section was duplicated
andygrove
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1847 +/- ##
============================================
+ Coverage 56.12% 59.40% +3.28%
- Complexity 976 1151 +175
============================================
Files 119 130 +11
Lines 11743 12663 +920
Branches 2251 2374 +123
============================================
+ Hits 6591 7523 +932
+ Misses 4012 3930 -82
- Partials 1140 1210 +70 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I reported the bug in DataFusion yesterday and there is already a fix apache/datafusion#16256 Perhaps this will be included in the 48.0.0 release, so moving this to draft for now. |
parthchandra
approved these changes
Jun 5, 2025
|
Thanks for the review @parthchandra. I will go ahead and merge this and then re-enable the tests once we upgrade to DataFusion 48 |
YanivKunda
pushed a commit
to YanivKunda/datafusion-comet
that referenced
this pull request
Jun 8, 2025
…e with count distinct on NaN in aggregate (apache#1847)
YanivKunda
pushed a commit
to YanivKunda/datafusion-comet
that referenced
this pull request
Jun 8, 2025
…e with count distinct on NaN in aggregate (apache#1847)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #1824
Rationale for this change
Comet is not compatible with Spark for aggregate queries that use the aggregate expression
count(distinct)on a column that containsNaNvalues. This appears to be a bug in DataFusion (apache/datafusion#16254).What changes are included in this PR?
Explain the bug in the compatibility guide and ignore the Spark SQL test.
Note that the Spark SQL test currently passes only because the query falls back to Spark, but this will no longer be the case once the
COMET_SHUFFLE_FALLBACK_TO_COLUMNARconfig is removed.We should eventually fix the bug, but let's at least document it for now.
How are these changes tested?