Skip to content

Enable clone_on_ref_ptr clippy lint on core crate #13338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Nov 12, 2024

Conversation

getChan
Copy link
Contributor

@getChan getChan commented Nov 10, 2024

Which issue does this PR close?

Part of #11143.

Rationale for this change

What changes are included in this PR?

apply clone_on_ref_ptr clippy lint on 'core' crate (except test)

but, concerned that many changes might cause conflicts.

Are these changes tested?

Are there any user-facing changes?

Copy link
Member

@jonahgao jonahgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @getChan . We should merge main to get CI passed.

@getChan
Copy link
Contributor Author

getChan commented Nov 12, 2024

LGTM, thanks @getChan . We should merge main to get CI passed.

@jonahgao main branch rebase completed

@jonahgao jonahgao merged commit 1bbe13f into apache:main Nov 12, 2024
25 checks passed
alamb pushed a commit to alamb/datafusion that referenced this pull request Nov 13, 2024
* Enable clone_on_ref_ptr clippy lint on physical-expr-common crate

* cargo fmt

* remove explicit type

* information_schema

* listing_schema

* memory

* avro_to_arrow.reader

* cte_worktable

* clone_on_ref_ptr

* type infer

* fmt

* except test

* after rebase main brach
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants