-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Enable clone_on_ref_ptr
clippy lint on core crate
#13338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahgao
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @getChan . We should merge main to get CI passed.
83f1630
to
122fdd4
Compare
alamb
pushed a commit
to alamb/datafusion
that referenced
this pull request
Nov 13, 2024
* Enable clone_on_ref_ptr clippy lint on physical-expr-common crate * cargo fmt * remove explicit type * information_schema * listing_schema * memory * avro_to_arrow.reader * cte_worktable * clone_on_ref_ptr * type infer * fmt * except test * after rebase main brach
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #11143.
Rationale for this change
What changes are included in this PR?
apply
clone_on_ref_ptr
clippy lint on 'core' crate (except test)but, concerned that many changes might cause conflicts.
Are these changes tested?
Are there any user-facing changes?