support recursive CTEs logical plans in datafusion-proto #13314
Merged
+434
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahgao
reviewed
Nov 10, 2024
| assert_eq!(format!("{plan:?}"), format!("{logical_round_trip:?}")); | ||
| assert_eq!( | ||
| format!("{}", pretty_format_batches(&output).unwrap()), | ||
| format!("{}", pretty_format_batches(&output_round_trip).unwrap()) |
There was a problem hiding this comment.
This assert_eq looks incorrect. output_round_trip and output are both the result of ctx.sql(query).
I think output_round_trip should be
let output_round_trip = ctx
.execute_logical_plan(logical_round_trip)
.await
.unwrap()
.collect()
.await
.unwrap()There was a problem hiding this comment.
You're absolutely right, and the corrected test was in fact failing! Despite the logical plans being equal, outputs were different.
| _node: Arc<dyn TableProvider>, | ||
| _buf: &mut Vec<u8>, | ||
| ) -> Result<(), DataFusionError> { | ||
| Ok(()) |
There was a problem hiding this comment.
It seems that we need to encode CteWorkTable and then recreate a CteWorkTable when decoding.🤔
There was a problem hiding this comment.
That is a great idea, I was able to implemented this correctly, without needing LogicalExtensionCodec by following your suggestion.
leoyvens
force-pushed
the
datafusion-proto-recursive-query
branch
from
f647230
to
d0401cf
Compare
|
@jonahgao thank you so much for your review, this PR is in much better shape now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Fixes a gap in support for logical plan serialization to protobuf.
What changes are included in this PR?
Adds support for serializing
LogicaPlan::RecursiveQueryto protobuf.Are these changes tested?
Yes, there is an unit test.
Are there any user-facing changes?
This feature is user visible.
Using it effectively is probably tricky due to the need to decode the provider for the CTE work table in theLogicalExtensionCodec. But still, this is a start.