fix(substrait): disallow union with a single input #13023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbarua
approved these changes
Oct 21, 2024
| "PrimaryAll Minus relation requires at least two inputs" | ||
| ) | ||
| Ok(set_op) => { | ||
| if set.inputs.len() >= 2 { |
Contributor
There was a problem hiding this comment.
minor: Would it be cleaner to pull this out to the top like
if set.inputs.len() <= 1 {
substrait_err!("Set operation requires at least two inputs")
}so it's clearer what the invariant is (by having the check right next to the error) and avoid indenting the match block?
(I'm not sure if this is idiomatic Rust)
Contributor
Author
There was a problem hiding this comment.
Can't really judge if it's idiomatic or not with my whole 2 weeks of rust experience 😆 but makes sense. I'll flip it.
Contributor
Marked it as API change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #12862
Are there any user-facing changes?
union with a single input no longer works (technically a breaking change)