Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: Signature check for UDAF #10147

Merged
merged 2 commits into from
Apr 21, 2024
Merged

Minor: Signature check for UDAF #10147

merged 2 commits into from
Apr 21, 2024

Conversation

jayzhan211
Copy link
Contributor

@jayzhan211 jayzhan211 commented Apr 20, 2024 •
edited
Loading

Which issue does this PR close?

Closes #.

Split from #10091

Rationale for this change

UDAF signature check is necessary like what built-in did.

What changes are included in this PR?

Are these changes tested?

Test is covered already 😄

datafusion/datafusion/sqllogictest/test_files/aggregate.slt

Lines 158 to 162 in 19356b2

query T?? rowsort
select column1, first_value(column3 order by column2, column4 desc), last_value(column3 order by column2, column4 desc) from array_agg_order_list_table group by column1;
----
b [7, 8, 9] [4, 5, 6]
w [3, 2, 5] [1, 2, 3]

Are there any user-facing changes?

@jayzhan211
add sig for udaf
d1bdeca 
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
@github-actions github-actions bot added the logical-expr Logical plan and expressions label Apr 20, 2024
@jayzhan211 jayzhan211 changed the title Signature check for UDAF Minor: Signature check for UDAF Apr 20, 2024
@jayzhan211
fix test
da0b19b 
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Jefffrey
Jefffrey approved these changes Apr 21, 2024
View reviewed changes
Copy link
Contributor

@Jefffrey Jefffrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jayzhan211
Copy link
Contributor Author

Thanks @Jefffrey

@jayzhan211 jayzhan211 merged commit 600b815 into apache:main Apr 21, 2024
23 checks passed
ccciudatu pushed a commit to hstack/arrow-datafusion that referenced this pull request Apr 26, 2024
@jayzhan211 @ccciudatu
Minor: Signature check for UDAF (apache#10147)
9404d34 
* add sig for udaf

Signed-off-by: jayzhan211 <jayzhan211@gmail.com>

* fix test

Signed-off-by: jayzhan211 <jayzhan211@gmail.com>

---------

Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jefffrey Jefffrey Jefffrey approved these changes

Assignees
No one assigned
Labels
logical-expr Logical plan and expressions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jayzhan211 @Jefffrey