Deprecate builtin first/last aggregate function and use UDAF #10091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
github-actions
bot
added
logical-expr
jayzhan211
changed the title
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
jayzhan211
commented
Apr 16, 2024
| }, | ||
| }); | ||
| } else if let Expr::Alias(alias) = expr.as_ref() { |
There was a problem hiding this comment.
Filed #10074 to see how to arrange the code here, replace with create_physical_sort_expr or others
jayzhan211
commented
Apr 16, 2024
| let mut sort_exprs = vec![]; | ||
| for expr in acc_args.sort_exprs { | ||
| if let Expr::Sort(sort) = expr { | ||
| if let Expr::Column(col) = sort.expr.as_ref() { |
There was a problem hiding this comment.
LastValue has no test case about Alias, so I keep it simple first.
jayzhan211
commented
Apr 16, 2024
| @@ -92,14 +90,13 @@ impl OptimizerRule for ReplaceDistinctWithAggregate { | |||
| let aggr_expr = select_expr | |||
| .iter() | |||
| .map(|e| { | |||
| Expr::AggregateFunction(AggregateFunction::new( | |||
| AggregateFunctionFunc::FirstValue, | |||
| create_first_value_expr( | |||
There was a problem hiding this comment.
Argument support in macro is another todo.
// "fluent expr_fn" style function
#[doc = $DOC]
pub fn $EXPR_FN($($arg: Expr),*) -> Expr {
Expr::AggregateFunction(datafusion_expr::expr::AggregateFunction::new_udf(
$AGGREGATE_UDF_FN(),
vec![$($arg),*],
// TODO: Support arguments for `expr` API
false,
None,
None,
None,
))
}
|
I plan to review this tomorrow (sorry I am out this week for vacation so I have more limited bandwidth) |
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
jayzhan211
commented
Apr 20, 2024
|
|
||
| if aggr_fun_expr.is_some_and(|e| e.fun().name() == "FIRST_VALUE") { | ||
| let mut first_value = aggr_fun_expr.unwrap().clone(); |
There was a problem hiding this comment.
where derive(Clone) is needed
jayzhan211
commented
Apr 20, 2024
| } | ||
|
|
||
| fn reverse_expr(&self) -> Option<Arc<dyn AggregateExpr>> { | ||
| Some(Arc::new(self.clone().convert_to_last())) |
There was a problem hiding this comment.
Note that reverse_expr is removed and manually converted in OptimizeAggregateOrder, but in Window function, get_best_fitting_window may call reverse_expr of first/last but no test is covered
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
This was referenced Apr 20, 2024
|
I think reverse_expr should be included before deprecate builtint first/last, so convert to draft. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #8708
Closes #9957 #10062
Rationale for this change
What changes are included in this PR?
Additionally, check the signature for UDAF, and extend it to support List.
Window Aggregate function also works with UDAF surprisingly without any change about the window function
Are these changes tested?
Are there any user-facing changes?