Minor: Switch LastValue SQL workflow to UDAF version#10062
Minor: Switch LastValue SQL workflow to UDAF version#10062jayzhan211 wants to merge 2 commits intoapache:mainfrom
Conversation
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
alamb
left a comment
There was a problem hiding this comment.
Thanks @jayzhan211 -- this looks very cool. I think we should remove the built in window function with the same PR so it is clear which versions are being used.
If we leave both in it will be quite confusing
|
To support replacing window first/last, there are many issues to be solved. Including replacing first/last in convert_firsts_last rule, and support sliding accumulator for udaf, and support list instead of NUMERIC signature. |
I wonder if starting with simpler aggregates (like
|
While I try to deprecate first/last, I found that window function can works with UDAF without additional change.
The issue I mentioned is part of a need for deprecating first/last, not for window function. This PR is pull out from #10091 to hope that I can minimize the change in that PR. |
Which issue does this PR close?
Closes #.
Part of #8708
Rationale for this change
After this change, LAST_VALUE goes to the registered UDAF instead of builtin one.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?