Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fallback to Spark when cannot resolve AttributeReference #926

Merged
merged 1 commit into from
Sep 9, 2024
Merged

fix: Fallback to Spark when cannot resolve AttributeReference #926

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1710,12 +1710,20 @@ object QueryPlanSerde extends Logging with ShimQueryPlanSerde with CometExprShim

if (dataType.isDefined) {
if (binding) {
val boundRef = BindReferences
.bindReference(attr, inputs, allowFailures = false)
.asInstanceOf[BoundReference]
// Spark may produce unresolvable attributes in some cases,
// for example https://github.com/apache/datafusion-comet/issues/925.
// So, we allow the binding to fail.
val boundRef: Any = BindReferences
.bindReference(attr, inputs, allowFailures = true)

if (boundRef.isInstanceOf[AttributeReference]) {
withInfo(attr, s"cannot resolve $attr among ${inputs.mkString(", ")}")
return None
}

val boundExpr = ExprOuterClass.BoundReference
.newBuilder()
.setIndex(boundRef.ordinal)
.setIndex(boundRef.asInstanceOf[BoundReference].ordinal)
.setDatatype(dataType.get)
.build()

Expand Down
Loading