Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fallback to Spark when cannot resolve AttributeReference #926

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

viirya
Copy link
Member

@viirya viirya commented Sep 9, 2024

Which issue does this PR close?

Closes #925.

Rationale for this change

What changes are included in this PR?

How are these changes tested?

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 34.04%. Comparing base (033fe6f) to head (3277195).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
.../scala/org/apache/comet/serde/QueryPlanSerde.scala 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               main     #926    +/-   ##
==========================================
  Coverage     34.03%   34.04%            
+ Complexity      883      882     -1     
==========================================
  Files           113      112     -1     
  Lines         43170    43293   +123     
  Branches       9516     9554    +38     
==========================================
+ Hits          14693    14739    +46     
- Misses        25471    25539    +68     
- Partials       3006     3015     +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@huaxingao huaxingao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@viirya viirya merged commit d095294 into apache:main Sep 9, 2024
75 checks passed
@viirya
Copy link
Member Author

viirya commented Sep 9, 2024

Thanks @huaxingao

@viirya viirya deleted the fallback branch September 9, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comet fails to translate partitioning expressions for unresolvable Spark expressions
3 participants