feat: Add support for TryCast expression in Spark 3.2 and 3.3 #416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
reviewed
May 15, 2024
Comment on lines
+666
to
+668
| case UnaryExpression(child) if expr.prettyName == "trycast" => | ||
| val timeZoneId = SQLConf.get.sessionLocalTimeZone | ||
| handleCast(child, inputs, expr.dataType, Some(timeZoneId), "TRY") |
andygrove
reviewed
May 15, 2024
andygrove
reviewed
May 15, 2024
| val value = cast.eval() | ||
| exprToProtoInternal(Literal(value, dataType), inputs) | ||
|
|
||
| case UnaryExpression(child) if expr.prettyName == "trycast" => |
There was a problem hiding this comment.
Just making sure whether it is trycast, not try_cast. Looks like Spark 3.4 is using try_cast, haven't been able to find the source for Spark 3.3
There was a problem hiding this comment.
yes, it is trycast.
kazuyukitanimura
approved these changes
May 15, 2024
viirya
reviewed
May 16, 2024
| // https://github.com/apache/datafusion-comet/issues/374 | ||
| val testTryCast = CometSparkSessionExtensions.isSpark34Plus | ||
|
|
||
| // we now support the TryCast expression in Spark 3.2 and 3.3 |
There was a problem hiding this comment.
nit: This comment looks unnecessary.
himadripal
pushed a commit
to himadripal/datafusion-comet
that referenced
this pull request
Sep 7, 2024
himadripal
pushed a commit
to himadripal/datafusion-comet
that referenced
this pull request
Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #374 .
Rationale for this change
Improve compatibility with various versions of spark.
What changes are included in this PR?
Inclusion of trycast while pattern matching expr
How are these changes tested?
All test cases pass.