Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

CB-14225 fix sample Namespace Serialize attribute in template/Properties/Default.rd.xml #286

Merged
merged 2 commits into from
Sep 2, 2018

Conversation

brodycj
Copy link

@brodycj brodycj commented Jul 27, 2018

Original issue

https://issues.apache.org/jira/browse/CB-14225

Platforms affected

Windows

What does this PR do?

  • Fix sample Namespace Serialize attribute in template/Properties/Default.rd.xml, according to Default.rd.xml in C# UWP project generated by Visual Studio 2017

I also raised microsoft/Windows-universal-samples#950 to apply a similar fix there.

Also related:

What testing has been done on this change?

  • Visual inspection
  • check diff

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

in template/Properties/Default.rd.xml
@brodycj brodycj changed the title CB-14225 fix sample Namespace Serialize attribute in template/Properties/Default.rd.xml - PROPOSAL WIP [WIP] CB-14225 fix sample Namespace Serialize attribute in template/Properties/Default.rd.xml - PROPOSAL FOR DISCUSSION Jul 27, 2018
@brodycj brodycj changed the title [WIP] CB-14225 fix sample Namespace Serialize attribute in template/Properties/Default.rd.xml - PROPOSAL FOR DISCUSSION CB-14225 fix sample Namespace Serialize attribute in template/Properties/Default.rd.xml Aug 1, 2018
@janpio janpio merged commit 03f482d into apache:master Sep 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants