This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
CB-14224 Default.rd.xml header fixes #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brodycj
changed the title
shazron
reviewed
Jul 27, 2018
| @@ -13,6 +13,28 @@ | |||
|
|
|||
| Using the Namespace directive to apply reflection policy to all the types in a particular namespace | |||
| <Namespace Name="DataClasses.ViewModels" Seralize="All" /> | |||
|
|
|||
There was a problem hiding this comment.
Is this missing the start of the xml comment block?
|
Thanks for the quick review. I am afraid that I don't really understand
your question. I think this piece of XML was intended as some kind of
optional instructions.
…On Thu, Jul 26, 2018, 9:24 PM Shazron Abdullah ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In template/Properties/Default.rd.xml
<#284 (comment)>
:
> @@ -13,6 +13,28 @@
Using the Namespace directive to apply reflection policy to all the types in a particular namespace
<Namespace Name="DataClasses.ViewModels" Seralize="All" />
+
Is this missing the start of the xml comment block?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#284 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABfNULbAJNGavRKlCYRaM5DBeMPegsT4ks5uKmvdgaJpZM4ViuSw>
.
|
|
Ah I see now, when viewing the whole file, i see the start of the comment block, my mistake, I thought you added the MIT license in there without it being a proper comment block. |
brodycj
changed the title
brodycj
changed the title
|
As this change is already part of 6.0.x (GH-285) it should now be in master. Title and description have been updated. |
janpio
pushed a commit
that referenced
this pull request
Sep 2, 2018
…ies/Default.rd.xml (#286) ### Original issue <https://issues.apache.org/jira/browse/CB-14225> ### Platforms affected Windows ### What does this PR do? - Fix sample Namespace Serialize attribute in `template/Properties/Default.rd.xml`, according to `Default.rd.xml` in C# UWP project generated by Visual Studio 2017 I also raised <microsoft/Windows-universal-samples#950> to apply a similar fix there. Also related: - #284 - fix license text & add link to `template/Properties/Default.rd.xml` (as reported in <https://issues.apache.org/jira/browse/CB-14224>) - <microsoft/Windows-universal-samples#949> - fix license txt (related to but not part of #284) ### What testing has been done on this change? - Visual inspection - check diff ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected. - ~~Added automated test coverage as appropriate for this change.~~
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original issue
https://issues.apache.org/jira/browse/CB-14224
Platforms affected
Windows
What does this PR do?
template/Properties/Default.rd.xmlheader fixes:Rationale: I think it is desired to add license headers whenever possible to satisfy Apache RAT license auditing tool. While I think it should be possible to configure the auditing tool to skip this file I would rather follow the practice of adding the license text whenever possible.
NOTE: I also proposed updates to LICENSE text in microsoft/Windows-universal-samples#949 (not included in this PR).
What testing has been done on this change?
I verified that
coho audit-license-headers -r windowswith these changes does not show the missing license header any more.Checklist
[ ] Added automated test coverage as appropriate for this change.