Plugin Audit proposal #58
Conversation
| * Open Pull Requests: 3 | ||
| * Spec: http://www.w3.org/TR/battery-status/ | ||
| * android 5 has the ability to grab battery info in uiwebview built in | ||
| * isPlugged is useful but not being used much |
There was a problem hiding this comment.
How can you tell that isPlugged is not being used much?
There was a problem hiding this comment.
Good Question. I don't think we have any stats.
| * Open Issues: 71 | ||
| * Open Pull Requests: 10 | ||
| * Spec: http://www.w3.org/TR/contacts-api/ (discontinued) | ||
| * API needs to be redone. Currently brittle and many platform specific quirks |
There was a problem hiding this comment.
Can you provide an example of brittleness? I'm curious what the perceived failings are.
There was a problem hiding this comment.
I think it was more around the fact that the tests pass/fail randomly it seems.
There was a problem hiding this comment.
Can we properly reflect that in the audit document, then?
| * Too many quirks between platforms | ||
| * Maybe implement web audio api spec instead as a plugin | ||
| * web audio supported in iOS 8.4+ and Android 5+ | ||
| * create web audio plugin for Android 4 to 4.4 |
There was a problem hiding this comment.
I think the latest cordova-android release dropped support for Android 4, no?
There was a problem hiding this comment.
4.1 and up are still supported, it was just 4.0.x that was dropped
| * looks ugly on ios | ||
| * currently not sync which is how default alerts work | ||
| * window.alert still available but says index.html | ||
| * Recommendation: Deprecate! Encourage use of HTML/CSS/JS divs instead. |
There was a problem hiding this comment.
-1 please do not deprecate, reasons given in comments below.
There was a problem hiding this comment.
Appreciate you providing feedback :)
|
I really hope the dialogs plugin does not go away for the following reasons:
For example my https://github.com/brodybits/Cordova-sqlite-bootstrap-test sample uses the dialogs plugin. |
|
May I suggest we pull download numbers once more, and compare against the 2015 numbers? Might provide a bit more insight. |
format table content formatting formatted and updated table for plugin downloads added updated data and charts for cordova plugin downloads
updated data+ charts for cordova plugin downloads
| * Can we treat some urls consistency across all platforms? Possibly use Flex Air package for inspiration. | ||
| * ex: app:, temp:, | ||
| * cdvfile wasn’t consistent enough across platforms | ||
| * Recommendation: Keep. Work on creating more consistency across platforms. Especially with cdvfile. Create phonegap-plugin-file with improved api. |
There was a problem hiding this comment.
Worth noting that our current implementation is a superset of the actual W3C spec: https://www.w3.org/TR/FileAPI
Things like FileEntry and similar APIs look to be discontinued now.
Our implementation is out of date.
Realized i accidentally closed the plugin audit PR.
#28