Plugin Audit proposal #28
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * demo of oauth workflow + demo of closing inappbrowser via js (url change) | ||
| * http://ngcordova.com/docs/plugins/oauth/ | ||
| * get rid of insertcss & executescript. Use fileapi instead | ||
| * Recommendation: Keep. Needs a refactor. Remove insertcss & executescript. Encourage use through apis instead of window.open. Make demos doing oAuth. Maybe phonegap-plugin-oauth. |
There was a problem hiding this comment.
Something based on SFSafariViewController (iOS) and Chrome Custom Tabs (Android) would be ideal. Some OAuth providers (Fitbit, for instance) have started adding restrictions that you're not allowed to do the OAuth flow in non-browser web views.
|
Looking really good. |
| * Can we treat some urls consistency across all platforms? Possibly use Flex Air package for inspiration. | ||
| * ex: app:, temp:, | ||
| * cdvfile wasn’t consistent enough across platforms | ||
| * Recommendation: Keep. Work on creating more consistency across platforms. Especially with cdvfile. Create phonegap-plugin-file with improved api. |
There was a problem hiding this comment.
Could use File wrapping in app-harness as one point of inspiration: https://github.com/apache/cordova-app-harness/blob/master/www/cdvah/js/ResourcesLoader.js#L149
There was a problem hiding this comment.
Thanks for the tip!
downstream distro (PG file?) discussion wasn't supposed to be in here. Just removed that line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.