Conversation
nvazquez
requested review from
Pearl1594,
davidjumani,
utchoang and
weizhouapache
Contributor
Author
|
@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
yadvr
approved these changes
Apr 2, 2022
Member
|
The only case worth checking is the SAML based SSO mechanism, not sure if the login method is hit; otherwise LGTM |
weizhouapache
approved these changes
Apr 4, 2022
Member
weizhouapache
left a comment
weizhouapache
left a comment
There was a problem hiding this comment.
code lgtm
I do not know if this fixes #6127
RodrigoDLopez
pushed a commit
to RodrigoDLopez/cloudstack
that referenced
this pull request
Aug 23, 2022
RodrigoDLopez
added a commit
to RodrigoDLopez/cloudstack
that referenced
this pull request
Aug 23, 2022
ui: Logout before login (apache#6193) See merge request scclouds/scclouds!264
shwstppr
pushed a commit
to shapeblue/cloudstack
that referenced
this pull request
Mar 13, 2023
* Add EncryptedElementType key resolver to SAML plugin * saml: Fix SAML SSO plugin redirect URL (apache#6457) This PR fixes the issue apache#6427 -> SAML request must be appended to an IdP URL as a query param with an ampersand, if the URL already contains a question mark, as opposed to always assume that IdP URLs don't have any query params. Google's IdP URL for instance looks like this: https://accounts.google.com/o/saml2/idp?idpid=<ID>, therefore the expected redirect URL would be https://accounts.google.com/o/saml2/idp?idpid=<ID>&SAMLRequest=<SAMLRequest> This code change is backwards compatible with the current behaviour. * Apply backport for SAML session cookie path apache#6149 * ui: Logout before login (apache#6193) This PR calls the logout API before login, to cleanup any duplicate sessionkey, as it was done on the legacy UI: apache#4326 Fixes: apache#6127 --------- Co-authored-by: Marcus Sorensen <mls@apple.com> Co-authored-by: Luis Moreira <Luis-3M@users.noreply.github.com> Co-authored-by: Nicolas Vazquez <nicovazquez90@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR calls the logout API before login, to cleanup any duplicate sessionkey, as it was done on the legacy UI: #4326
Fixes: #6127
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?