ui: call logout before login to clear old sessionkey cookies#4326
Merged
yadvr merged 1 commit intoapache:masterfrom Sep 17, 2020
Merged
ui: call logout before login to clear old sessionkey cookies#4326yadvr merged 1 commit intoapache:masterfrom
yadvr merged 1 commit intoapache:masterfrom
Conversation
This handle edge cases of upgrades and when legacy UI is used along with Primate or any UI sharing cookies. The specific case it fixes involves removal of duplicate sessionkey cookies. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
yadvr
requested review from
GabrielBrascher,
andrijapanicsb,
svenvogel and
wido
Member
Author
|
Please review - @Pearl1594 @davidjumani @utchoang @andrijapanicsb @svenvogel and rest. Thnx |
|
@blueorangutan package |
|
@utchoang a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
Member
Author
|
Sorry @utchoang the blueorangutan package for old UI wont' setup a live demo to test that |
|
@rhtyd OK. I'll run and test on my local. Thnks |
yadvr
pushed a commit
that referenced
this pull request
Apr 6, 2022
shwstppr
pushed a commit
to shapeblue/cloudstack
that referenced
this pull request
Mar 13, 2023
* Add EncryptedElementType key resolver to SAML plugin * saml: Fix SAML SSO plugin redirect URL (apache#6457) This PR fixes the issue apache#6427 -> SAML request must be appended to an IdP URL as a query param with an ampersand, if the URL already contains a question mark, as opposed to always assume that IdP URLs don't have any query params. Google's IdP URL for instance looks like this: https://accounts.google.com/o/saml2/idp?idpid=<ID>, therefore the expected redirect URL would be https://accounts.google.com/o/saml2/idp?idpid=<ID>&SAMLRequest=<SAMLRequest> This code change is backwards compatible with the current behaviour. * Apply backport for SAML session cookie path apache#6149 * ui: Logout before login (apache#6193) This PR calls the logout API before login, to cleanup any duplicate sessionkey, as it was done on the legacy UI: apache#4326 Fixes: apache#6127 --------- Co-authored-by: Marcus Sorensen <mls@apple.com> Co-authored-by: Luis Moreira <Luis-3M@users.noreply.github.com> Co-authored-by: Nicolas Vazquez <nicovazquez90@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This handle edge cases of upgrades and when legacy UI is used along with
Primate or any UI sharing cookies. The specific case it fixes involves
removal of duplicate sessionkey cookies.
Fixes #4324
Types of changes
How Has This Been Tested?
$.cookie('sessionkey', '123')With the fix, when logout is called the API will clear sessionkey cookie (which is httponly so only the backend/server can remove it); and login works. This will cover issues after upgrades and when using legacy UI with Primate: