[VMware] Start VM with deploy-as-is template having multiple controller types by sureshanaparti · Pull Request #5311 · apache/cloudstack

sureshanaparti · 2021-08-13T05:33:28Z

Description

This PR fixes the deploy / start VM issue in VMware, with deploy-as-is template (OVA) having multiple controller types.

Fixes: #5111

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Manually tested deploy / start using OVA template having multiple controller types.

sureshanaparti · 2021-08-13T05:35:46Z

@blueorangutan package

blueorangutan · 2021-08-13T05:36:03Z

@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-08-13T06:01:29Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian. SL-JID 862

DaanHoogland

code looks good, if this really solves the issue : merge.
@sureshanaparti is sorting really all that is needed? Did you try multiple orderings of disks in the template ?

DaanHoogland · 2021-08-13T07:32:00Z

...ns/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java

+                Collections.sort(vmDisks, new Comparator<VirtualDisk>() {
+                    @Override
+                    public int compare(VirtualDisk disk1, VirtualDisk disk2) {
+                        Integer controllerKey1 = disk1.getControllerKey();
+                        Integer controllerKey2 = disk2.getControllerKey();
+                        return controllerKey1.compareTo(controllerKey2);
+                    }
+                });
+


can you extract this utility?

can you extract this utility?

done

sureshanaparti · 2021-08-13T08:02:11Z

code looks good, if this really solves the issue : merge.
@sureshanaparti is sorting really all that is needed? Did you try multiple orderings of disks in the template ?

@DaanHoogland the disks are returns in random order, and so there is mismatch in the mapping of disks.

sureshanaparti · 2021-08-13T10:06:39Z

@blueorangutan package

blueorangutan · 2021-08-13T10:07:02Z

@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-08-13T10:29:09Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian. SL-JID 864

sureshanaparti · 2021-08-13T10:32:21Z

@blueorangutan test centos7 vmware-67u3

blueorangutan · 2021-08-13T10:33:03Z

@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

nvazquez · 2021-08-16T02:46:29Z

@blueorangutan test centos7 vmware-67u3

blueorangutan · 2021-08-16T02:47:02Z

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

blueorangutan · 2021-08-16T13:48:50Z

Trillian test result (tid-1644)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38389 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5311-t1644-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
Smoke tests completed. 88 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_05_ping_in_cpvm_success	`Failure`	60.48	test_diagnostics.py

nvazquez · 2021-08-18T15:01:00Z

Needs manual testing, marking as draft until then

yadvr · 2021-08-27T10:52:40Z

@sureshanaparti does this affect 4.15 too? If so, pl raise PR against 4.15 branch.

…oller types.

sureshanaparti · 2021-08-30T04:52:24Z

@blueorangutan package

blueorangutan · 2021-08-30T04:53:03Z

@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-08-30T05:38:46Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian. SL-JID 1056

sureshanaparti · 2021-08-30T05:53:28Z

@blueorangutan test centos7 vmware-67u3

blueorangutan · 2021-08-30T05:54:04Z

@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

blueorangutan · 2021-08-30T17:13:15Z

Trillian test result (tid-1834)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37335 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5311-t1834-vmware-67u3.zip
Smoke tests completed. 87 look OK, 0 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File

nvazquez

LGTM - Tested using deploy-as-is on templates with multiple controller types

sureshanaparti mentioned this pull request Aug 13, 2021

[VMware] Unable to start VM from template having multiple controller types #5111

Closed

DaanHoogland approved these changes Aug 13, 2021

View reviewed changes

sureshanaparti requested review from harikrishna-patnala and nvazquez August 13, 2021 07:58

sureshanaparti force-pushed the vmware-multiple-controllers branch from 6ad6087 to 25dddcd Compare August 13, 2021 08:28

yadvr approved these changes Aug 13, 2021

View reviewed changes

yadvr added this to the 4.16.0.0 milestone Aug 16, 2021

nvazquez marked this pull request as draft August 16, 2021 14:42

nvazquez approved these changes Aug 16, 2021

View reviewed changes

sureshanaparti marked this pull request as ready for review August 18, 2021 13:33

nvazquez marked this pull request as draft August 18, 2021 15:01

nvazquez added component:vmware status:needs-testing type:bug labels Aug 25, 2021

nvazquez changed the base branch from main to 4.15 August 27, 2021 17:27

nvazquez changed the base branch from 4.15 to main August 27, 2021 17:27

Start VM with deploy-as-is template having multiple disk (SCSI) contr…

c3beef4

…oller types.

sureshanaparti force-pushed the vmware-multiple-controllers branch from 25dddcd to c3beef4 Compare August 30, 2021 04:51

sureshanaparti changed the base branch from main to 4.15 August 30, 2021 04:51

sureshanaparti modified the milestones: 4.16.0.0, 4.15.2.0 Aug 30, 2021

nvazquez marked this pull request as ready for review August 30, 2021 23:28

nvazquez approved these changes Aug 31, 2021

View reviewed changes

nvazquez merged commit e50a40e into apache:4.15 Aug 31, 2021

DaanHoogland removed the status:needs-testing label Jan 28, 2026

Conversation

sureshanaparti commented Aug 13, 2021

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

sureshanaparti commented Aug 13, 2021

Uh oh!

blueorangutan commented Aug 13, 2021

Uh oh!

blueorangutan commented Aug 13, 2021

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland Aug 13, 2021

Choose a reason for hiding this comment

Uh oh!

sureshanaparti Aug 13, 2021

Choose a reason for hiding this comment

Uh oh!

sureshanaparti commented Aug 13, 2021

Uh oh!

sureshanaparti commented Aug 13, 2021

Uh oh!

blueorangutan commented Aug 13, 2021

Uh oh!

blueorangutan commented Aug 13, 2021

Uh oh!

sureshanaparti commented Aug 13, 2021

Uh oh!

blueorangutan commented Aug 13, 2021

Uh oh!

nvazquez commented Aug 16, 2021

Uh oh!

blueorangutan commented Aug 16, 2021

Uh oh!

blueorangutan commented Aug 16, 2021

Uh oh!

nvazquez commented Aug 18, 2021

Uh oh!

yadvr commented Aug 27, 2021

Uh oh!

sureshanaparti commented Aug 30, 2021

Uh oh!

blueorangutan commented Aug 30, 2021

Uh oh!

blueorangutan commented Aug 30, 2021

Uh oh!

sureshanaparti commented Aug 30, 2021

Uh oh!

blueorangutan commented Aug 30, 2021

Uh oh!

blueorangutan commented Aug 30, 2021

Uh oh!

nvazquez left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants