[VMware] Start VM with deploy-as-is template having multiple disk (SCSI) controller types.

Author: sureshanaparti

plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java

@@ -2632,6 +2632,15 @@ private void mapSpecDisksToClonedDisksAndTearDownDatadisks(VirtualMachineMO vmMo
             s_logger.debug("Mapping spec disks information to cloned VM disks for VM " + vmInternalCSName);
             if (vmMo != null && ArrayUtils.isNotEmpty(specDisks)) {
                 List<VirtualDisk> vmDisks = vmMo.getVirtualDisks();
+                Collections.sort(vmDisks, new Comparator<VirtualDisk>() {
+                    @Override
+                    public int compare(VirtualDisk disk1, VirtualDisk disk2) {
+                        Integer controllerKey1 = disk1.getControllerKey();
+                        Integer controllerKey2 = disk2.getControllerKey();
+                        return controllerKey1.compareTo(controllerKey2);
+                    }
+                });
+
                 List<VirtualDisk> rootDisks = new ArrayList<>();
                 List<DiskTO> sortedRootDisksFromSpec = Arrays.asList(sortVolumesByDeviceId(specDisks))
                         .stream()