PAX: Move cpp-stub as subdir #1238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiaqizho
force-pushed
the
change-cpp-stub-repo
branch
from
c6503ed to
a18bef1
Compare
|
That would be better to revise the commit message body like this: |
tuhaihe
reviewed
Jul 17, 2025
|
Also, we need to update the related license files and pom.xml -- will be checked and done in another PR. FYI. |
12 tasks
jiaqizho
force-pushed
the
change-cpp-stub-repo
branch
from
a18bef1 to
b65d3de
Compare
tuhaihe
approved these changes
Jul 23, 2025
2 tasks
my-ship-it
approved these changes
Jul 23, 2025
During the IPMC release review, bundled .a binary files were found in the cpp-stub git submodule. These violate ASF policy, which prohibits including prebuilt binaries in source releases. To resolve this, we removed the cpp-stub submodule and copied only the required source files into the repository as a subdirectory. This ensures compliance with ASF release requirements. Source upstream commit: coolxv/cpp-stub@2ec4837 See: apache#1237
tuhaihe
force-pushed
the
change-cpp-stub-repo
branch
from
b65d3de to
c298dd8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions