Pin submodule dependencies to specific versions #1212
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
|
|
tuhaihe
force-pushed
the
fixed-submodules
branch
from
9ddfd9c to
23dd1df
Compare
|
This PR adopts the way recommended by @edespino here: #1084 (review) |
leborchuk
reviewed
Sep 8, 2025
There was a problem hiding this comment.
It looks good for me that we cannot use the branch syntax, as a specific branch could be deleted from the original repo.
The similar, HEAD could contain breaking changes, so we cannot guarantee backward compatibility with third-party repositories.
Therefore, it would be wise to pin a specific commit and, for example, update it in each new release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To enhance build stability and reproducibility, this PR updates the
submodule pointers to lock them to specific, stable release tags.
Previously, several submodules were tracking the HEAD of a branch or were
not explicitly version-locked. This practice can lead to inconsistent
builds, as unintended upstream changes could be pulled in, causing
unexpected failures or behavior changes.
By pinning each submodule to a specific commit hash corresponding to a
release tag, we ensure that all developers and CI environments use the
exact same version of the dependencies, guaranteeing a consistent and
reproducible build process.
Note
This PR includes a few commits. Please don't squash them into one commit when merging this PR to the main branch. Please select
Rebase and mergeinstead ofSquash and merge!What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions