Adding ecaudit plugin to connection whitelist. #1321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One test failed because of what looks like a flakey environment setup. |
|
@CH-JosephBironas you can use a custom Authenticator using #1242. That being said, if the use of this authenticator is common, I wouldn't mind adding it to the whitelist. |
|
The problem with it not being added to the whitelist is, I have to maintain custom forks of two other largish projects that depend on this one in order to implement the same user/pass auth that exist already in this library. If there are no objections to augmenting the white list, that is the least effort for at least me, and I imagine others who depend on audit logging in cassandra pre the 4.0 release. |
|
Confirmed the travisci build was flakey. |
meiliang86
added a commit
to cadence-workflow/cadence
that referenced
this pull request
Jan 6, 2020
* Update gocql to pull in apache/cassandra-gocql-driver#1321 * fix test Co-authored-by: Matt Anger <58711323+AngerM-DD@users.noreply.github.com> Co-authored-by: Yu Xia <yx@uber.com> Co-authored-by: Liang Mei <meiliang86@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a seemingly trivial change to a plugin whitelist. It uses a drop-in replacement to cassandra username/password auth to create an audit log for compliance purposes.
Edit: To address issue #1320